Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): Multi source apps resolve revision in .status field (#13859) #14081

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix(controller): Multi source apps resolve revision in .status field (#13859) #14081

merged 1 commit into from
Jun 15, 2023

Conversation

JorTurFer
Copy link
Contributor

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Please see Contribution FAQs if you have questions about your pull-request.

Fixes #13859

@JorTurFer
fix: Multi source apps resolve revision in .status field
641b116 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@crenshaw-dev crenshaw-dev changed the title fix: Multi source apps resolve revision in .status field (#13859) fix(controller): Multi source apps resolve revision in .status field (#13859) Jun 15, 2023
@crenshaw-dev crenshaw-dev merged commit 435d175 into argoproj:master Jun 15, 2023
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.7

@crenshaw-dev
Copy link
Member

/cherry-pick release-2.6

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 15, 2023
@JorTurFer
fix: Multi source apps resolve revision in .status field (#14081)
3ad8bab 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 15, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 15, 2023
@JorTurFer
fix: Multi source apps resolve revision in .status field (#14081)
a45302f 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 15, 2023
Merged
crenshaw-dev pushed a commit that referenced this pull request Jun 15, 2023
@gcp-cherry-pick-bot @JorTurFer
fix: Multi source apps resolve revision in .status field (#14081) (#1…
dd565e7 
…4086)

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
crenshaw-dev pushed a commit that referenced this pull request Jun 15, 2023
@gcp-cherry-pick-bot @JorTurFer
fix: Multi source apps resolve revision in .status field (#14081) (#1…
9ce19c6 
…4087)

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer JorTurFer deleted the fix-revisions branch June 15, 2023 21:50
@crenshaw-dev crenshaw-dev mentioned this pull request Jun 18, 2023
Closed
3 tasks
@woehrl01 woehrl01 mentioned this pull request Jun 20, 2023
Merged
13 tasks
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
@gcp-cherry-pick-bot @JorTurFer @schakrad
fix: Multi source apps resolve revision in .status field (argoproj#14081
5125c22 
) (argoproj#14086)

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@JorTurFer
fix: Multi source apps resolve revision in .status field (argoproj#14081
da56901 
)

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
@JorTurFer @tesla59
fix: Multi source apps resolve revision in .status field (argoproj#14081
5840a02 
)

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi source apps don't contain resolved revision in .status field
2 participants
@JorTurFer @crenshaw-dev