Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Revert "feat: add monaco-kubernetes for editing IntelliSense (#12778)" (#13671) #14000

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

crenshaw-dev
Copy link
Member

This reverts commit f8e016d.

Fixes #13671

…j#12778)"

This reverts commit f8e016d.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (698aef3) 49.61% compared to head (d6cabbe) 49.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14000      +/-   ##
==========================================
- Coverage   49.61%   49.61%   -0.01%     
==========================================
  Files         256      256              
  Lines       43934    43934              
==========================================
- Hits        21800    21797       -3     
- Misses      19975    19977       +2     
- Partials     2159     2160       +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast track

@pasha-codefresh pasha-codefresh merged commit 3a1030b into argoproj:master Jun 19, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…j#12778)" (argoproj#14000)

This reverts commit f8e016d.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…j#12778)" (argoproj#14000)

This reverts commit f8e016d.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

UI is trying to load JSON from https://plugins.monokle.com
3 participants