Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump otel dependencies #13798

Merged
merged 3 commits into from
May 30, 2023

Conversation

crenshaw-dev
Copy link
Member

Dependabot was upgrading one at a time. This gets them all at once.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (944eadd) 49.25% compared to head (91f3606) 49.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #13798   +/-   ##
=======================================
  Coverage   49.25%   49.25%           
=======================================
  Files         251      251           
  Lines       43521    43521           
=======================================
  Hits        21438    21438           
  Misses      19949    19949           
  Partials     2134     2134           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to to configure dependabot to group relevant dependency upgrades?

@crenshaw-dev
Copy link
Member Author

@terrytangyuan it's automatic for JS @types packages, but otherwise I don't think there's a grouping mechanism. Looks like it might be added soon though: dependabot/dependabot-core#1190 (comment)

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 30, 2023 18:17
@crenshaw-dev crenshaw-dev merged commit fb4dd6c into argoproj:master May 30, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@alexmt alexmt mentioned this pull request Aug 22, 2023
3 tasks
@crenshaw-dev crenshaw-dev deleted the bump-otel-dependencies branch August 22, 2023 21:54
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants