-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appset): Support AWS CodeCommit in ApplicationSet controller (Alpha) #13579
feat(appset): Support AWS CodeCommit in ApplicationSet controller (Alpha) #13579
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13579 +/- ##
==========================================
+ Coverage 49.09% 49.25% +0.16%
==========================================
Files 250 251 +1
Lines 43248 43518 +270
==========================================
+ Hits 21231 21435 +204
- Misses 19889 19949 +60
- Partials 2128 2134 +6
☔ View full report in Codecov by Sentry. |
2faeca3
to
af453c9
Compare
Signed-off-by: Joseph Zhang <jzhang@absolute.com>
Signed-off-by: Joseph Zhang <jzhang@absolute.com>
…er error Signed-off-by: Joseph Zhang <jzhang@absolute.com>
Signed-off-by: Joseph Zhang <jzhang@absolute.com>
af453c9
to
5d67bfe
Compare
…decommit Signed-off-by: Joseph Zhang <jzhang@absolute.com>
Signed-off-by: Joseph Zhang <jzhang@absolute.com>
b286ba0
to
d28157b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This implementation is slightly more complex than other SCM providers. I think it would be a great candidate to externalize to a plugin generator in the future. But for now, code looks good, happy to have it upstream.
…pha) (argoproj#13579) * feat: add aws codecommit support to ApplicationSet controller Signed-off-by: Joseph Zhang <jzhang@absolute.com> * feat: codegen for ApplicationSet controller AWS CodeCommit support Signed-off-by: Joseph Zhang <jzhang@absolute.com> * feat: ApplicationSet controller AWS CodeCommit support - address linter error Signed-off-by: Joseph Zhang <jzhang@absolute.com> * docs: add AWS CodeCommit support Signed-off-by: Joseph Zhang <jzhang@absolute.com> * feat(appset): address PR feedbacks for AWS CodeCommit SCM provider Signed-off-by: Joseph Zhang <jzhang@absolute.com> --------- Signed-off-by: Joseph Zhang <jzhang@absolute.com>
…pha) (argoproj#13579) * feat: add aws codecommit support to ApplicationSet controller Signed-off-by: Joseph Zhang <jzhang@absolute.com> * feat: codegen for ApplicationSet controller AWS CodeCommit support Signed-off-by: Joseph Zhang <jzhang@absolute.com> * feat: ApplicationSet controller AWS CodeCommit support - address linter error Signed-off-by: Joseph Zhang <jzhang@absolute.com> * docs: add AWS CodeCommit support Signed-off-by: Joseph Zhang <jzhang@absolute.com> * feat(appset): address PR feedbacks for AWS CodeCommit SCM provider Signed-off-by: Joseph Zhang <jzhang@absolute.com> --------- Signed-off-by: Joseph Zhang <jzhang@absolute.com>
What
Closes #13496 . This PR implements initial support for AWS CodeCommit as scmProvider in ApplicationSet controller. Please refer to the linked issue for the original enhancement proposal.
Additional considerations
Tests
Although unit tests coverage is decent, we can only go so far testing AWS APIs. I've manually tested the build in my ArgoCD environment to verify most scenarios supported by this PR. However, if there's any AWS test infrastructure for ArgoCD project, we could further add integration tests to gain additional confidence.
Original Notes
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.