Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appset): Support AWS CodeCommit in ApplicationSet controller (Alpha) #13579

Merged
merged 6 commits into from
May 29, 2023

Conversation

jzhn
Copy link
Contributor

@jzhn jzhn commented May 13, 2023

What

Closes #13496 . This PR implements initial support for AWS CodeCommit as scmProvider in ApplicationSet controller. Please refer to the linked issue for the original enhancement proposal.

Additional considerations

Tests

Although unit tests coverage is decent, we can only go so far testing AWS APIs. I've manually tested the build in my ArgoCD environment to verify most scenarios supported by this PR. However, if there's any AWS test infrastructure for ArgoCD project, we could further add integration tests to gain additional confidence.

Original Notes

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@jzhn jzhn changed the title feat: Support AWS CodeCommit in ApplicationSet controller feat: Support AWS CodeCommit in ApplicationSet controller (Alpha) May 13, 2023
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Patch coverage: 75.55% and project coverage change: +0.16 🎉

Comparison is base (4c982b2) 49.09% compared to head (d28157b) 49.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13579      +/-   ##
==========================================
+ Coverage   49.09%   49.25%   +0.16%     
==========================================
  Files         250      251       +1     
  Lines       43248    43518     +270     
==========================================
+ Hits        21231    21435     +204     
- Misses      19889    19949      +60     
- Partials     2128     2134       +6     
Impacted Files Coverage Δ
applicationset/generators/scm_provider.go 33.53% <0.00%> (-1.25%) ⬇️
.../apis/application/v1alpha1/applicationset_types.go 28.57% <ø> (ø)
...icationset/services/scm_provider/aws_codecommit.go 77.27% <77.27%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jzhn jzhn force-pushed the feat/app-set-aws-codecommit branch 2 times, most recently from 2faeca3 to af453c9 Compare May 19, 2023 17:31
jzhn added 4 commits May 19, 2023 14:55
Signed-off-by: Joseph Zhang <jzhang@absolute.com>
Signed-off-by: Joseph Zhang <jzhang@absolute.com>
…er error

Signed-off-by: Joseph Zhang <jzhang@absolute.com>
Signed-off-by: Joseph Zhang <jzhang@absolute.com>
@jzhn jzhn force-pushed the feat/app-set-aws-codecommit branch from af453c9 to 5d67bfe Compare May 19, 2023 23:18
@leoluz leoluz self-assigned this May 25, 2023
@crenshaw-dev crenshaw-dev changed the title feat: Support AWS CodeCommit in ApplicationSet controller (Alpha) feat(appset): Support AWS CodeCommit in ApplicationSet controller (Alpha) May 29, 2023
jzhn added 2 commits May 29, 2023 11:37
…decommit

Signed-off-by: Joseph Zhang <jzhang@absolute.com>
Signed-off-by: Joseph Zhang <jzhang@absolute.com>
@jzhn jzhn force-pushed the feat/app-set-aws-codecommit branch from b286ba0 to d28157b Compare May 29, 2023 19:49
@jzhn jzhn requested a review from crenshaw-dev May 29, 2023 21:13
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

This implementation is slightly more complex than other SCM providers. I think it would be a great candidate to externalize to a plugin generator in the future. But for now, code looks good, happy to have it upstream.

@crenshaw-dev crenshaw-dev merged commit d685f15 into argoproj:master May 29, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…pha) (argoproj#13579)

* feat: add aws codecommit support to ApplicationSet controller

Signed-off-by: Joseph Zhang <jzhang@absolute.com>

* feat: codegen for ApplicationSet controller AWS CodeCommit support

Signed-off-by: Joseph Zhang <jzhang@absolute.com>

* feat: ApplicationSet controller AWS CodeCommit support - address linter error

Signed-off-by: Joseph Zhang <jzhang@absolute.com>

* docs: add AWS CodeCommit support

Signed-off-by: Joseph Zhang <jzhang@absolute.com>

* feat(appset): address PR feedbacks for AWS CodeCommit SCM provider

Signed-off-by: Joseph Zhang <jzhang@absolute.com>

---------

Signed-off-by: Joseph Zhang <jzhang@absolute.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…pha) (argoproj#13579)

* feat: add aws codecommit support to ApplicationSet controller

Signed-off-by: Joseph Zhang <jzhang@absolute.com>

* feat: codegen for ApplicationSet controller AWS CodeCommit support

Signed-off-by: Joseph Zhang <jzhang@absolute.com>

* feat: ApplicationSet controller AWS CodeCommit support - address linter error

Signed-off-by: Joseph Zhang <jzhang@absolute.com>

* docs: add AWS CodeCommit support

Signed-off-by: Joseph Zhang <jzhang@absolute.com>

* feat(appset): address PR feedbacks for AWS CodeCommit SCM provider

Signed-off-by: Joseph Zhang <jzhang@absolute.com>

---------

Signed-off-by: Joseph Zhang <jzhang@absolute.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

[ApplicationSet] support AWS CodeCommit SCM Provider Generator
3 participants