-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appset): Add target branch support pullrequestgenerator #13535
feat(appset): Add target branch support pullrequestgenerator #13535
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13535 +/- ##
==========================================
+ Coverage 48.98% 49.23% +0.25%
==========================================
Files 249 248 -1
Lines 43066 42844 -222
==========================================
Hits 21094 21094
+ Misses 19864 19651 -213
+ Partials 2108 2099 -9
☔ View full report in Codecov by Sentry. |
937ad3c
to
dc641df
Compare
a83e51e
to
8829dab
Compare
…lter TargetBranchFilter for AppSet PullRequestGenerator Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
8829dab
to
c9668d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Syst3m1cAn0maly!
…upport-pullrequestgenerator Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…j#13535) * Add support for templates target_branch and target_branch_slug and filter TargetBranchFilter for AppSet PullRequestGenerator Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com> * Update PullRequestGenerator documentation Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com> * Adjust field number for the new TargetBranchFilter Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com> * Add generated api files, Fix e2e failing test Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com> --------- Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
…j#13535) * Add support for templates target_branch and target_branch_slug and filter TargetBranchFilter for AppSet PullRequestGenerator Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com> * Update PullRequestGenerator documentation Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com> * Adjust field number for the new TargetBranchFilter Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com> * Add generated api files, Fix e2e failing test Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com> --------- Signed-off-by: Syst3m1An0maly <mehdi.chtayti@gmail.com>
Closes #13533
Support a target_branch template which retrieves the target branch of the Pull Request when using the PullRequestGenerator for AppSets.
Also add a target_branch_slug analog to branch_slug.
Add a targetBranchFilter to allow filtering of the Pull Request based on the target branch using a regex.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.