fix: broken Git file generator caching (fixes #13440) #13452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13452 +/- ##
==========================================
- Coverage 49.15% 49.15% -0.01%
==========================================
Files 248 248
Lines 42891 42893 +2
==========================================
Hits 21082 21082
- Misses 19691 19693 +2
Partials 2118 2118
☔ View full report in Codecov by Sentry. |
Calchan
changed the title
Calchan
changed the title
Calchan
force-pushed
the
fix_git_generator_caching
branch
from
1ecf858
to
a11c620
Compare
|
@gdsoumya can you please take a look? |
alexmt
approved these changes
May 4, 2023
auto-merge was automatically disabled
May 4, 2023 17:36
Head branch was pushed to by a user without write access
Calchan
force-pushed
the
fix_git_generator_caching
branch
from
a11c620
to
9aba418
Compare
Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>
auto-merge was automatically disabled
May 4, 2023 18:21
Head branch was pushed to by a user without write access
Calchan
force-pushed
the
fix_git_generator_caching
branch
from
9aba418
to
94562a0
Compare
Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>
auto-merge was automatically disabled
May 4, 2023 18:45
Head branch was pushed to by a user without write access
Calchan
force-pushed
the
fix_git_generator_caching
branch
from
94562a0
to
1521782
Compare
Open
3 tasks
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…oj#13452) * chore: add .*.swp to .gitignore for Vim users Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com> * fix: add search pattern to Git file generator cache key (argoproj#13440) Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com> --------- Signed-off-by: Denis Dupeyron <denis.dupeyron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Git file generator currently assumes that only a single Git file generator will ever exist for any repository. If multiple generators exist the cache will always return the results of the first file search that randomly happened to all subsequent searches.
This PR adds the search pattern to the Git file generator cache key in order to individualize cache entries for the Git file generator.
Note that
reposerver/cache/types.gois deleted since it is no longer needed.Fixes #13440
Checklist: