Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MariaDB CRD health checks #13143

Merged
merged 5 commits into from
May 4, 2023
Merged

feat: add MariaDB CRD health checks #13143

merged 5 commits into from
May 4, 2023

Conversation

Vidalee
Copy link
Contributor

@Vidalee Vidalee commented Apr 6, 2023

The PR adds health check for MariaDB CRD which is used by mariadb-operator

All the possible conditions states are handled (see the controller source code)

Fixes the issue where the MariaDB CRD is Healthy and ready but the StatefulSet is still deploying the server pod or a backup is currently being restored.


Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
    Note: No issues related
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.12 🎉

Comparison is base (ceed653) 49.01% compared to head (483db28) 49.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13143      +/-   ##
==========================================
+ Coverage   49.01%   49.14%   +0.12%     
==========================================
  Files         247      248       +1     
  Lines       42685    42891     +206     
==========================================
+ Hits        20924    21079     +155     
- Misses      19645    19693      +48     
- Partials     2116     2119       +3     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mmontes11
Copy link

mmontes11 commented Apr 18, 2023

Could we get a review here please? 👀 Thanks again for your contributions @Vidalee !

mariadb-operator is growing in adoption and it would be awesome to integrate with ArgoCD, let us now if you need anything else!

cc @jessesuen @jannfis @alexmt

Copy link
Contributor

@drpaneas drpaneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thx for providing extra knowledge to argocd for mariadb :)

Signed-off-by: Thomas Sirvent <vivi@vivide.re>
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Vidalee!

@crenshaw-dev crenshaw-dev merged commit ef39bd2 into argoproj:master May 4, 2023
@Vidalee Vidalee deleted the mariadb-health-check branch May 4, 2023 23:37
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
* feat: add MariaDB CRD health checks

Signed-off-by: Thomas Sirvent <vivi@vivide.re>

* feat: set Degraded health on MariaDB CRD error

Signed-off-by: Thomas Sirvent <vivi@vivide.re>

* style: add missing newline

Signed-off-by: Thomas Sirvent <vivi@vivide.re>

---------

Signed-off-by: Thomas Sirvent <vivi@vivide.re>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants