Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add scalability benchmarking proposal #12662

Merged

Conversation

morey-tech
Copy link
Contributor

@morey-tech morey-tech commented Feb 28, 2023

Scalability Benchmarking Proposal

Presented at the 2023-03-01 community meeting. The recording is available here.

If you are interested in joining the SIG Scalability, add a comment here: feat(sig): add scalability group #192. Meetings are held on the 2nd and 4th Wednesday of every month.

The proposal to create the argoproj-labs/argo-cd-benchmarking repo has been created and is ready for review!

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@morey-tech morey-tech added enhancement New feature or request type:scalability Issues related to scalability and performance related issues labels Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.43 🎉

Comparison is base (6971966) 47.78% compared to head (b0b46eb) 49.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12662      +/-   ##
==========================================
+ Coverage   47.78%   49.22%   +1.43%     
==========================================
  Files         246      248       +2     
  Lines       41944    42830     +886     
==========================================
+ Hits        20045    21084    +1039     
+ Misses      19898    19648     -250     
- Partials     2001     2098      +97     

see 62 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Copy link
Contributor

@sbose78 sbose78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the initiative. Red Hat would love to collaborate.

docs/proposals/004-scalability-benchmarking.md Outdated Show resolved Hide resolved
@morey-tech
Copy link
Contributor Author

morey-tech commented Mar 1, 2023

From the 2023-03-01 community meeting:

  • Add "tooling" (raw manifests, Helm, Kustomize) to the Key Scalability Factors.
  • Add "AWS will provide EKS cluster(s) for testing" to the implementation details.
  • Add creating Scalability SIG to the proposal as the first step.
  • Create a proposal in argoproj/argoproj to create the argoproj-labs/argo-cd-benchmarking repo.

@csantanapr
Copy link
Member

@sbose78

Love the initiative. Red Hat would love to collaborate.
Looking forward on collaborating with Red Hat folks

@csantanapr
Copy link
Member

@morey-tech Do we want to flip this PR from Draft to ready for review?

@morey-tech morey-tech marked this pull request as ready for review March 2, 2023 16:45
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@csantanapr
Copy link
Member

@morey-tech do you need to edit the PR for DCO to pass?

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@morey-tech morey-tech force-pushed the scalability-benchmarking-proposal branch from 8c546ee to b0b46eb Compare May 16, 2023 16:25
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 16, 2023 17:17
@crenshaw-dev crenshaw-dev merged commit c2a1181 into argoproj:master May 16, 2023
@morey-tech morey-tech deleted the scalability-benchmarking-proposal branch May 16, 2023 18:07
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
* docs: add scalability benchmarking proposal

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* fix: add andklee as co-author

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* fix: wording fixes

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* feat: add comment on "realworld-ness"

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* feat: add tooling to key scalability factors

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* feat: add aws to implementation details

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* fix: add additional goal of being vendor-agnostic

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* feat: add namespaced topology

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* fix: namespace topology intent

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* feat: add initial members section

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

* fix: grammarly

Signed-off-by: Nicholas Morey <nicholas@morey.tech>

---------

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-review size/M type:scalability Issues related to scalability and performance related issues
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants