fix: trigger refresh on changed ignoreDifferences #12607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #12607 +/- ##
=======================================
Coverage 49.25% 49.25%
=======================================
Files 251 251
Lines 43521 43525 +4
=======================================
+ Hits 21438 21440 +2
- Misses 19949 19951 +2
Partials 2134 2134
☔ View full report in Codecov by Sentry. |
…-ignore-differences Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…-ignore-differences Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
Because this PR contains a CRD change, I'm not sure whether we should cherry-pick it except for the upcoming 2.7 release. Personally, I would expect patch releases not to touch any CRDs or deployment manifests (with certain exceptions). |
|
@jannfis agreed, dropped the cherry-pick comments. LGTY otherwise? |
…-ignore-differences Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
|
/cherry-pick release-2.8 |
…-ignore-differences Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
* fix: trigger refresh on changed ignoreDifferences Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * make the tests mean things Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev
added a commit
that referenced
this pull request
Jul 11, 2023
* fix: trigger refresh on changed ignoreDifferences * make the tests mean things --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* fix: trigger refresh on changed ignoreDifferences Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * make the tests mean things Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Closed
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* fix: trigger refresh on changed ignoreDifferences Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> * make the tests mean things Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12610
Tested locally and confirmed I can't reproduce the reported issue.