Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add gitlab.SystemHookEvents to support Gitlab system events #12547

Merged

Conversation

kamuridesu
Copy link
Contributor

@kamuridesu kamuridesu commented Feb 20, 2023

Closes #9625

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Closes [ISSUE argoproj#9625]

Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (e8f5126) 49.76% compared to head (eb3f6f0) 49.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12547      +/-   ##
==========================================
- Coverage   49.76%   49.75%   -0.01%     
==========================================
  Files         261      261              
  Lines       44653    44653              
==========================================
- Hits        22222    22219       -3     
- Misses      20248    20250       +2     
- Partials     2183     2184       +1     
Impacted Files Coverage Δ
util/webhook/webhook.go 69.56% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pasha-codefresh pasha-codefresh merged commit a3591cd into argoproj:master Jun 27, 2023
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
…oproj#12547)

* fix: add gitlab.SystemHookEvents to support Gitlab system events

Closes [ISSUE argoproj#9625]

Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>

* tests(gitlab.SystemHookEvents): fix tests for gitlab.SystemHookEvents

Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>

---------

Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
…oproj#12547)

* fix: add gitlab.SystemHookEvents to support Gitlab system events

Closes [ISSUE argoproj#9625]

Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>

* tests(gitlab.SystemHookEvents): fix tests for gitlab.SystemHookEvents

Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>

---------

Signed-off-by: Kamuri Amorim <myk.gata14@gmail.com>
Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GitLab "System Hook" push webhooks
2 participants