feat: specify listen address from env / command line #11846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyusupov
force-pushed
the
listen-addr-latest
branch
from
13e88f3
to
62c2934
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #11846 +/- ##
==========================================
- Coverage 49.07% 49.07% -0.01%
==========================================
Files 250 250
Lines 43244 43244
==========================================
- Hits 21224 21221 -3
- Misses 19890 19892 +2
- Partials 2130 2131 +1
☔ View full report in Codecov by Sentry. |
eyusupov
force-pushed
the
listen-addr-latest
branch
2 times, most recently
from
7dd0888
to
d64b1a3
Compare
eyusupov
force-pushed
the
listen-addr-latest
branch
2 times, most recently
from
b9f8c5e
to
9fc6e89
Compare
Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com>
eyusupov
force-pushed
the
listen-addr-latest
branch
from
9fc6e89
to
bfa3cc4
Compare
crenshaw-dev
requested changes
May 27, 2023
Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com>
|
@eyusupov thanks for the changes! Can you fix the DCO check? Looks like you'll also need to run |
Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com>
Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com>
eyusupov
force-pushed
the
listen-addr-latest
branch
from
963e166
to
faf7634
Compare
crenshaw-dev
approved these changes
May 29, 2023
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* feat: specify listen address from env / command line Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com> * Make listen addrs configurable through ConfigMap Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com> * Update autogenerated manifests Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com> --------- Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* feat: specify listen address from env / command line Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com> * Make listen addrs configurable through ConfigMap Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com> * Update autogenerated manifests Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com> --------- Signed-off-by: Eldar Yusupov <eldar.yusupov@workato.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Closes #12564
Checklist: