-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add more info to creationtime format #10493
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10493 +/- ##
=======================================
Coverage 45.69% 45.69%
=======================================
Files 234 234
Lines 28508 28508
=======================================
Hits 13027 13027
Misses 13694 13694
Partials 1787 1787 ☔ View full report in Codecov by Sentry. |
ui/src/app/applications/components/application-summary/application-summary.tsx
Show resolved
Hide resolved
@rbreeze Would you be able to review the code? Changes are related to UI polish no functional change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after changing type any
Signed-off-by: Ashutosh <mail.ashutosh8@gmail.com>
Signed-off-by: ashutosh16 <mail.ashutosh8@gmail.com>
Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
f20a75c
to
dc7059a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @ashutosh16!
This commit adds a new flag, `permitOnlyProjectScopedClusters`, which prevents any application from syncing to clusters which are not a part of the same project. Fixes argoproj#10220. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> docs: remove duplicate word in user-management doc (argoproj#10546) Signed-off-by: Mickaël Canévet <mickael.canevet@jellysmack.com> Signed-off-by: Mickaël Canévet <mickael.canevet@jellysmack.com> fix: hide terminal on the non-pod resource kind (argoproj#9980) (argoproj#10556) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> fix: add more info to creationtime format (argoproj#10286) (argoproj#10493) * fix: add more info to creationtime format Signed-off-by: Ashutosh <mail.ashutosh8@gmail.com> * lint issue Signed-off-by: ashutosh16 <mail.ashutosh8@gmail.com> * fix: add more info to creationtime format Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Signed-off-by: Ashutosh <mail.ashutosh8@gmail.com> Signed-off-by: ashutosh16 <mail.ashutosh8@gmail.com> Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com> Co-authored-by: Ashutosh <mail.ashutosh8@gmail.com> feat: support multiple sources for application Signed-off-by: ishitasequeira <ishiseq29@gmail.com> remove debug logging and unwanted code Signed-off-by: ishitasequeira <ishiseq29@gmail.com> fix lint and unit test errors Signed-off-by: ishitasequeira <ishiseq29@gmail.com> fix lint and unit test errors Signed-off-by: ishitasequeira <ishiseq29@gmail.com> Merge branch 'multiple-sources-for-applications' of github.com:ishitasequeira/argo-cd into multiple-sources-for-applications feat: support multiple sources for application Signed-off-by: ishitasequeira <ishiseq29@gmail.com> remove debug logging and unwanted code Signed-off-by: ishitasequeira <ishiseq29@gmail.com> fix lint and unit test errors Signed-off-by: ishitasequeira <ishiseq29@gmail.com> fix lint and unit test errors Signed-off-by: ishitasequeira <ishiseq29@gmail.com> fix bug introduced after rebase Signed-off-by: ishitasequeira <ishiseq29@gmail.com> executed make codegen Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
Signed-off-by: Ashutosh mail.ashutosh8@gmail.com
Fixes #10286
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: