-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#9963):Add logic to handle for fileHandle.Close() #10361
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10361 +/- ##
==========================================
- Coverage 45.94% 45.92% -0.02%
==========================================
Files 229 229
Lines 28268 28278 +10
==========================================
Hits 12987 12987
- Misses 13510 13518 +8
- Partials 1771 1773 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One enhancement request. Thanks as always @my-git9!
6c23eaa
to
254d3ac
Compare
Signed-off-by: xin.li <xin.li@daocloud.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
…proj#10361) Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: Yi Cai <yicai@redhat.com>
* fix: missing actions (#10327) (#10359) Signed-off-by: CI <michael@crenshaw.dev> Signed-off-by: CI <michael@crenshaw.dev> Signed-off-by: Yi Cai <yicai@redhat.com> * chore: infer managed resources health from redis instead of storing it in CRD (#10191) * chore: infer managed resources health from redis instead of storing it in CRD Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * apply reviewer notes Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com> * fix: Add logic to handle for fileHandle.Close() (#9963) (#10361) Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: Yi Cai <yicai@redhat.com> * docs: fix typo in upgrade notes (#10377) Signed-off-by: Xijun Dai <daixijun1990@gmail.com> Signed-off-by: Xijun Dai <daixijun1990@gmail.com> Signed-off-by: Yi Cai <yicai@redhat.com> * fix: add space before prompt in CLI (#10362) Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: Yi Cai <yicai@redhat.com> * docs: fix indentation of example AppProject in 'Sync Windows' documentation (#10388) Signed-off-by: Yi Cai <yicai@redhat.com> * fix: Correctly assume cluster-scoped resources to be self-referenced (#10390) Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: Yi Cai <yicai@redhat.com> * ui-make-https-repo-credential-editable Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Minor format fix Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Minor fix for unclickable input field Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Updates for comments Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * ui-make-https-repo-credential-editable Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Minor format fix Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Minor fix for unclickable input field Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> * Updates for comments Signed-off-by: ciiay <yicai@redhat.com> Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: CI <michael@crenshaw.dev> Signed-off-by: Yi Cai <yicai@redhat.com> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: xin.li <xin.li@daocloud.io> Signed-off-by: Xijun Dai <daixijun1990@gmail.com> Signed-off-by: jannfis <jann@mistrust.net> Signed-off-by: ciiay <yicai@redhat.com> Co-authored-by: Michael Crenshaw <michael@crenshaw.dev> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: my-git9 <xin.li@daocloud.io> Co-authored-by: Xijun Dai <daixijun1990@gmail.com> Co-authored-by: Jun Duan <jun.duan@ibm.com> Co-authored-by: jannfis <jann@mistrust.net>
Add logic to handle for fileHandle.Close()
Checklist: