Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod logs horizontal scroll is per line instead of all lines #16411

Closed
3 tasks done
maartengo opened this issue Nov 21, 2023 · 7 comments
Closed
3 tasks done

Pod logs horizontal scroll is per line instead of all lines #16411

maartengo opened this issue Nov 21, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@maartengo
Copy link

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

Scrolling in the log view of pods/deployments/etc. only scrolls per line, instead of all lines together. This is similar to what happened in #14387.

To Reproduce

  1. Start a pod that logs multiple long lines (redis does this)
  2. Open the pod logs in Argo
  3. Try to scroll horizontally

Expected behavior

I expect a horizontal scroll bar, and for all logs to scroll simultaneously instead of individually.

Screenshots

Recording.2023-11-20.084540.mp4

Version

{
    "Version": "v2.9.1+58b04e5",
    "BuildDate": "2023-11-14T15:08:20Z",
    "GitCommit": "58b04e5e11d007b0518853029ff7612c24a2eb35",
    "GitTreeState": "clean",
    "GoVersion": "go1.21.3",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v5.2.1 2023-10-19T20:13:51Z",
    "HelmVersion": "v3.12.1+gf32a527",
    "KubectlVersion": "v0.24.2",
    "JsonnetVersion": "v0.20.0"
}

Logs

Paste any relevant application logs here.
@maartengo maartengo added the bug Something isn't working label Nov 21, 2023
@maartengo
Copy link
Author

@ciiay could you take a look at this bug? I think that your change from 30e06d6 broke horizontal scrolling, but I'm not well versed enough in front-ends to see what went wrong.

@maartengo
Copy link
Author

I took another look at the commit I linked, but it seems more likely that this commit caused the issue; 795f225

@crenshaw-dev
Copy link
Member

I can reproduce this in 2.9.1.

@ciiay
Copy link
Contributor

ciiay commented Dec 22, 2023

Got it, I will take a look at this issue when I'm back in new year.

alexmt pushed a commit that referenced this issue Jan 5, 2024
* Fixed log horizontal scroll

Signed-off-by: Yi Cai <yicai@redhat.com>

* Updated log line-height

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Jan 5, 2024
* Fixed log horizontal scroll

Signed-off-by: Yi Cai <yicai@redhat.com>

* Updated log line-height

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Jan 5, 2024
* Fixed log horizontal scroll

Signed-off-by: Yi Cai <yicai@redhat.com>

* Updated log line-height

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
crenshaw-dev pushed a commit that referenced this issue Jan 5, 2024
* Fixed log horizontal scroll



* Updated log line-height



---------

Signed-off-by: Yi Cai <yicai@redhat.com>
Co-authored-by: Yi Cai <yicai@redhat.com>
crenshaw-dev pushed a commit that referenced this issue Jan 5, 2024
* Fixed log horizontal scroll



* Updated log line-height



---------

Signed-off-by: Yi Cai <yicai@redhat.com>
Co-authored-by: Yi Cai <yicai@redhat.com>
ebuildy pushed a commit to ebuildy/argo-cd that referenced this issue Jan 7, 2024
…j#16727)

* Fixed log horizontal scroll

Signed-off-by: Yi Cai <yicai@redhat.com>

* Updated log line-height

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: ebuildy <ebuildy@gmail.com>
@alexec
Copy link
Contributor

alexec commented Jan 8, 2024

I noticed this yesterday myself and found it … unintuitive. Not like a normal log viewer.

I’m only commenting to help hint that it’s a real issue.

@Sineaggi
Copy link

Sineaggi commented Jan 9, 2024

Can we get a test for this so it doesn't break again?

JulienFuix pushed a commit to JulienFuix/argo-cd that referenced this issue Feb 6, 2024
…j#16727)

* Fixed log horizontal scroll

Signed-off-by: Yi Cai <yicai@redhat.com>

* Updated log line-height

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
@jgwest
Copy link
Member

jgwest commented Feb 9, 2024

Yi's PR has merged.

@jgwest jgwest closed this as completed Feb 9, 2024
penglongli pushed a commit to penglongli/argo-cd that referenced this issue Mar 6, 2024
…j#16727)

* Fixed log horizontal scroll

Signed-off-by: Yi Cai <yicai@redhat.com>

* Updated log line-height

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: penglongli <pelenli@tencent.com>
lyda pushed a commit to lyda/argo-cd that referenced this issue Mar 28, 2024
…j#16727)

* Fixed log horizontal scroll

Signed-off-by: Yi Cai <yicai@redhat.com>

* Updated log line-height

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
Hariharasuthan99 pushed a commit to AmadeusITGroup/argo-cd that referenced this issue Jun 16, 2024
…j#16727)

* Fixed log horizontal scroll

Signed-off-by: Yi Cai <yicai@redhat.com>

* Updated log line-height

Signed-off-by: Yi Cai <yicai@redhat.com>

---------

Signed-off-by: Yi Cai <yicai@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants