apply suggestions

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

docs/operator-manual/argocd-cm.yaml

@@ -289,5 +289,5 @@ data:
   # exec.enabled indicates whether the UI exec feature is enabled. It is disabled by default.
   exec.enabled: "false"
 
-  # exec.shells determines which shells are allowed for `exec`, and in which order they are attempted
+  # exec.shells restricts which shells are allowed for `exec`, and in which order they are attempted
   exec.shells: "bash,sh,powershell,cmd"

server/application/websocket.go

@@ -27,7 +27,7 @@ type terminalSession struct {
 	sizeChan chan remotecommand.TerminalSize
 	doneChan chan struct{}
 	tty      bool
-	readMu   sync.Mutex
+	readLock sync.Mutex
 }
 
 // newTerminalSession create terminalSession
@@ -62,9 +62,9 @@ func (t *terminalSession) Next() *remotecommand.TerminalSize {
 
 // Read called in a loop from remotecommand as long as the process is running
 func (t *terminalSession) Read(p []byte) (int, error) {
-	t.readMu.Lock()
+	t.readLock.Lock()
 	_, message, err := t.wsConn.ReadMessage()
-	t.readMu.Unlock()
+	t.readLock.Unlock()
 	if err != nil {
 		log.Errorf("read message err: %v", err)
 		return copy(p, EndOfTransmission), err

util/settings/settings.go

@@ -99,7 +99,7 @@ type ArgoCDSettings struct {
 	ServerRBACLogEnforceEnable bool `json:"serverRBACLogEnforceEnable"`
 	// ExecEnabled indicates whether the UI exec feature is enabled
 	ExecEnabled bool `json:"execEnabled"`
-	// ExecShells determines which shells are allowed for `exec` and in which order they are tried
+	// ExecShells restricts which shells are allowed for `exec` and in which order they are tried
 	ExecShells []string `json:"execShells"`
 	// TrackingMethod defines the resource tracking method to be used
 	TrackingMethod string `json:"application.resourceTrackingMethod,omitempty"`