Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Feat/pull request generator #366

Merged
merged 6 commits into from
Sep 29, 2021

Conversation

shmurata
Copy link
Contributor

@shmurata shmurata commented Sep 7, 2021

The new generator proposed at #210 has been implemented as a Pull Request Generator.
Although the Pull Request Generator is similar to the SCM Provider Generator in some aspects, it seems that various changes are necessary to incorporate it into the SCM Provider Generator, so I have implemented it as a separate generator.
In the future, it may be possible to merge them.

I've implemented it to add other providers as well, but this PR only supports Github.
I can't implement other providers because I don't use them.

The requeue interval is polled in this PR, but I'd like to add webhook support to this generator after #341 is merged.

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @shmurata! A couple of tweaks requested... and it looks like you need to add the new generator doc file to mkdocs.yml as well.

api/v1alpha1/applicationset_types.go Show resolved Hide resolved
docs/Generators-Pull-Request.md Outdated Show resolved Hide resolved
test/e2e/applicationset/applicationset_test.go Outdated Show resolved Hide resolved
docs/Generators.md Outdated Show resolved Hide resolved
@shmurata
Copy link
Contributor Author

@jgwest Thanks for the review.
I would like to respond to your comments.
If there is anything else you would like to see fixed or recommend, it would be appreciated if you could comment on it.

@shmurata
Copy link
Contributor Author

Added to mkdocs.yml in 6e81ce5.

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks @shmurata , and thanks for your patience 😅 .

@jgwest jgwest merged commit dcba500 into argoproj:master Sep 29, 2021
@enys
Copy link

enys commented Oct 2, 2021

Thanks for this !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants