Upgrade Argo Workflow to 3.5.5

[Sharathmk99]

Pull Request Checklist

• Fixes Upgrade Argo >= 3.5 #993
• Tests added
• Documentation/examples added
• Good commit messages and/or PR title

Description of PR
Currently, we are on 3.4.4 Argo Workflow version and need to Upgrade Argo Workflow models to >= 3.5 version to use features like pod_gc deleteDelayDuration.

This is my first PR on this repo, please let me know if I need to update any other files or add more tests, will do.
Thank you!!

[elliotgunton]

Hi @Sharathmk99, thanks for the PR! Looking through the changes, the model updates look backward compatible, so should be good there. Our on-cluster test however has failed when using 3.5.5 due to

message='Error (exit code 1): pods "hello-world-79zj8-echo-1727487450" is forbidden: User "system:serviceaccount:argo:default" cannot patch resource "pods" in API group "" in the namespace "argo"',

This probably just requires a fix for the role in the cluster setup in

hera/Makefile

Lines 156 to 157 in eed2294

	kubectl apply -n argo -f https://github.com/argoproj/argo-workflows/releases/download/v$(ARGO_WORKFLOWS_VERSION)/install.yaml
	kubectl patch deployment argo-server --namespace argo --type='json' -p='[{"op": "replace", "path": "/spec/template/spec/containers/0/args", "value": ["server", "--auth-mode=server"]}]'

Or it may be related to submitting as user argoproj/argo-workflows#12391

I will look into this if/when I have time unless you get to it first. Thanks!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (d553546) to head (4c76961).
Report is 41 commits behind head on main.

❗ Current head 4c76961 differs from pull request most recent head 070292c. Consider uploading reports for the commit 070292c to get more accurate results

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #994   +/-   ##
=====================================
  Coverage   81.7%   81.8%           
=====================================
  Files         54      56    +2     
  Lines       4208    4235   +27     
  Branches     889     893    +4     
=====================================
+ Hits        3439    3465   +26     
+ Misses       574     572    -2     
- Partials     195     198    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Sharathmk99]

Hi @Sharathmk99, thanks for the PR! Looking through the changes, the model updates look backward compatible, so should be good there. Our on-cluster test however has failed when using 3.5.5 due to

message='Error (exit code 1): pods "hello-world-79zj8-echo-1727487450" is forbidden: User "system:serviceaccount:argo:default" cannot patch resource "pods" in API group "" in the namespace "argo"',

This probably just requires a fix for the role in the cluster setup in

hera/Makefile

Lines 156 to 157 in eed2294

	kubectl apply -n argo -f https://github.com/argoproj/argo-workflows/releases/download/v$(ARGO_WORKFLOWS_VERSION)/install.yaml
	kubectl patch deployment argo-server --namespace argo --type='json' -p='[{"op": "replace", "path": "/spec/template/spec/containers/0/args", "value": ["server", "--auth-mode=server"]}]'

Or it may be related to submitting as user argoproj/argo-workflows#12391

I will look into this if/when I have time unless you get to it first. Thanks!

@elliotgunton thank you for the input. I'll have look at it today. Will update.