fix(UserContainer): Fix a small bug in ImagePullPolicy mapper and add tests for error cases #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KengoA <20113339+KengoA@users.noreply.github.com>
Signed-off-by: KengoA <20113339+KengoA@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 54 54
Lines 4208 4208
Branches 889 889
=====================================
+ Hits 3439 3441 +2
+ Misses 574 572 -2
Partials 195 195 ☔ View full report in Codecov by Sentry. |
KengoA
commented
Feb 16, 2024
Comment on lines
-40
to
-43
| # some users might submit the policy without underscores | ||
| **{ipp.value.lower().replace("_", ""): ipp for ipp in ImagePullPolicy}, | ||
| # some users might submit the policy in lowercase | ||
| **{ipp.name.lower(): ipp for ipp in ImagePullPolicy}, |
There was a problem hiding this comment.
These were not accessing the intended values and created duplicate key-value pairs.
Reference:
# src/hera/workflows/models/io/k8s/api/core/v1.py
class ImagePullPolicy(Enum):
always = "Always"
never = "Never"
if_not_present = "IfNotPresent"
There was a problem hiding this comment.
Good find, thanks! cc @flaviuvadan JFYI 👀
KengoA
requested review from
flaviuvadan,
samj1912 and
elliotgunton
as code owners
elliotgunton
added
semver:patch
elliotgunton
approved these changes
Feb 16, 2024
Comment on lines
-40
to
-43
| # some users might submit the policy without underscores | ||
| **{ipp.value.lower().replace("_", ""): ipp for ipp in ImagePullPolicy}, | ||
| # some users might submit the policy in lowercase | ||
| **{ipp.name.lower(): ipp for ipp in ImagePullPolicy}, |
There was a problem hiding this comment.
Good find, thanks! cc @flaviuvadan JFYI 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
When checking for string values of
image_pull_policyin theUserContainerclass, the current implementation was adding redundant items in thepolicy_mapperdict as it was confusing thenameandvalueproperties.This PR simplifies this logic while covering the same use cases, and adds tests for normal and error cases.