Refactor "one or many" typed Hera values #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgunton
added
semver:patch
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
=====================================
Coverage 80.3% 80.3%
=====================================
Files 49 49
Lines 3821 3831 +10
Branches 777 779 +2
=====================================
+ Hits 3069 3079 +10
Misses 557 557
Partials 195 195 ☔ View full report in Codecov by Sentry. |
flaviuvadan
reviewed
Dec 21, 2023
flaviuvadan
reviewed
Dec 21, 2023
flaviuvadan
reviewed
Dec 21, 2023
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently, typing a value as a single value of a union or a list of the same union is verbose and becomes less readable. This PR adds an explicit
OneOrManytype for us to reuse throughout the mixins, as well as validators that can normalize the value to a list (or as an alternative valid single-value).The issue also discusses moving the
_build_*logic into the root validator - we could do something like that instead of thenormalize_to_listfunctions, but chose to get to this halfway point first.