-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on-cluster workflow test to CI #887
Conversation
9418063
to
9662192
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great as a first version!
Also def open to k3d as Sam mentioned
3c068ba
to
1bbdec0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
=====================================
Coverage 79.7% 79.7%
=====================================
Files 45 45
Lines 3722 3722
Branches 754 754
=====================================
Hits 2970 2970
Misses 558 558
Partials 194 194 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
2eff881
to
5a61b08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM! The next iteration can address some of the other concerns you mentioned in the description. Thx again for adding this <3
Pull Request Checklist
Description of PR
Introduce local Argo cluster workflow tests to CI, and
make
targets to set up a local cluster for testing (this worked very well on GitHub codespaces, where I could even get a web UI to the cluster).Added a single test to confirm the workflow runs via
create
and reaches thesucceeded
status.phase
. We can think about creating a more flexible/extensible framework for addingon_cluster
tests -status.phase
, e.g. output values, running order, skipped nodes etc, which would require bespoke tests for eachstatus.nodes
dictionary, which is keyed by hashes, so you have to checkdisplayName
from the values.