Revert "Revert "Add Pydantic Extra.forbid to shared base model config ""
#881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviuvadan
added
semver:patch
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
=======================================
+ Coverage 79.7% 79.8% +0.1%
=======================================
Files 45 45
Lines 3706 3743 +37
Branches 750 763 +13
=======================================
+ Hits 2955 2989 +34
- Misses 558 561 +3
Partials 193 193 ☔ View full report in Codecov by Sentry. |
| """uses smart union for matching a field's specified value to the underlying type that's part of a union""" | ||
| """uses smart union for matching a field's specified value to the underlying type that's part of a union.""" | ||
|
|
||
| extra = Extra.forbid |
There was a problem hiding this comment.
Maybe we can turn it off when interacting with the server to solve the underlying issue?
There was a problem hiding this comment.
Yea, probably.. I am surprised that the fields on the return payload may not match the fields on the autogen code though :(
|
Closing this as it's getting stale (and is just a revert commit). Going to reopen the issue and we can reprioritise and come back to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #880