Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mounting volume for outputs #780

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Allow mounting volume for outputs #780

merged 2 commits into from
Sep 26, 2023

Commits on Sep 26, 2023

  1. Fixup volumes 

    * Do not use /tmp for script outputs
* Allow mounting own volume with use_volume_for_outputs
* Fix examples using volumes incorrectly and simplify where possible
* Fix passing artifacts as argument (remove path), and simplify examples

Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
    @elliotgunton
    elliotgunton committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b904455 View commit details
    Browse the repository at this point in the history

  2. Pass in volume for hera outputs 

    Allows users to set outputs_directory and volume_for_outputs
separately, meaning they can use a different /tmp path, mount
a new empty dir, or use an existing volume, all of which now
have tests

Signed-off-by: Elliot Gunton <egunton@bloomberg.net>
    @elliotgunton
    elliotgunton committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    c5a42e5 View commit details
    Browse the repository at this point in the history