Remove Python 3.8 support #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgunton
added
semver:minor
elliotgunton
force-pushed
the
remove-3.8
branch
2 times, most recently
from
94ed183
to
a0f4566
Compare
elliotgunton
added a commit
that referenced
this pull request
Sep 16, 2024
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
jeongukjae
reviewed
Sep 16, 2024
elliotgunton
added a commit
that referenced
this pull request
Sep 16, 2024
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
samj1912
added a commit
that referenced
this pull request
Sep 16, 2024
We need to remove 3.8 from the "required" cicd checks so that #1202 can pass --------- Signed-off-by: Elliot Gunton <elliotgunton@gmail.com> Signed-off-by: Sambhav Kothari <sambhavs.email@gmail.com> Co-authored-by: Sambhav Kothari <skothari44@bloomberg.net>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
* Removed `ast` copy used for `roundtrip` function. Moved `roundtrip` to be private static funtion of InlineScriptConstructor where it's only used once (except for tests) * Removed `graphib` copy used to generate model files * Updated configs Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
* Fix two tests that had removed service_account_name from the spec Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
elliotgunton
force-pushed
the
remove-3.8
branch
from
80df288
to
d5afb76
Compare
samj1912
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Tests addedDocumentation/examples addedDescription of PR
Removes 3.8 support which is end of life next month. The commits are mostly 1-1 with the list of tasks in the issue, most of the changes are automatic, only some manual changes to the
roundtripfunction along with configs etc.