Fix new container decorator example #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
elliotgunton
added
semver:patch
elliotgunton
commented
Aug 28, 2024
| @@ -26,5 +26,9 @@ class MyOutput(Output): | |||
|
|
|||
|
|
|||
| @w.set_entrypoint | |||
| @w.container(command=["sh", "-c"], args=["echo Hello {{inputs.parameters.user}} | tee /tmp/hello_world.txt"]) | |||
| @w.container( | |||
| image="busybox", | |||
There was a problem hiding this comment.
This is the only manual change in this PR
samj1912
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
New container decorator example was using a
pythonimage as theimagewasn't set in the decorator kwargs (and instead used the defaultglobal_config.imagein theContainerMixinvalidator). Also ranmake regenerate-test-datato fix examples.