Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in IfNotPresent pollicy support #687

Closed
levplotkin opened this issue Jun 20, 2023 · 1 comment · Fixed by #689
Closed

Bug in IfNotPresent pollicy support #687

levplotkin opened this issue Jun 20, 2023 · 1 comment · Fixed by #689
Labels
note:ideal-for-contribution An issue that a contributor can help us with semver:patch A change requiring a patch version bump type:bug A general bug

Comments

@levplotkin
Copy link

https://github.com/argoproj-labs/hera/blob/e398eff8dbd36b9385dff21a39ae6c8abf11f343/src/hera/workflows/_mixins.py#LL152C1-L152C69

for image pull policy 'IfNotPresent'
ImagePullPolicy['IfNotPresent'.lower()].value gives a KeyError: 'ifnotpresent'
I had to fix it on the application side by using the ImagePullPolicy object instead
like
container.image_pull_policy = 'IfNotPresent'
container.image_pull_policy = ImagePullPolicy(container.image_pull_policy)
@levplotkin levplotkin changed the title IfNotPresent pollicy support Bug in IfNotPresent pollicy support Jun 20, 2023
@elliotgunton elliotgunton added type:bug A general bug note:ideal-for-contribution An issue that a contributor can help us with semver:patch A change requiring a patch version bump labels Jun 20, 2023
@flaviuvadan
Copy link
Collaborator

Thanks for reporting this @levplotkin! We'll try to make the fix part of the next release, which will happen this week

@flaviuvadan flaviuvadan mentioned this issue Jun 20, 2023
Merged
4 tasks
flaviuvadan added a commit that referenced this issue Jun 20, 2023
@flaviuvadan
[#687] Adjust image pull policy inference (#689)
b10dfa5 
**Pull Request Checklist**
- [x] Fixes #687
- [ ] Tests added
- [x] Documentation/examples added
- [x] [Good commit messages](https://cbea.ms/git-commit/) and/or PR
title

**Description of PR**

This PR adds a small mapping of possible user inputs to map to
`ImagePullPolicy` objects as a QOL improvement/bug fix

---------

Signed-off-by: Flaviu Vadan <flaviuvadan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
note:ideal-for-contribution An issue that a contributor can help us with semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#687] Adjust image pull policy guessing engine argoproj-labs/hera
3 participants
@levplotkin @elliotgunton @flaviuvadan