Skip to content

Commit

Permalink
Fix mypy default args issues in Workflow (#918)
Browse files Browse the repository at this point in the history
**Pull Request Checklist**
- [ ] Towards fixing #911
- [ ] Tests added
- [ ] Documentation/examples added
- [ ] [Good commit messages](https://cbea.ms/git-commit/) and/or PR
title

**Description of PR**
Fixes mypy linting issues with default args for mixin fields of
arguments, metrics, volumes in workflow.py

Signed-off-by: Max Shatkhin <mshatkhin23@users.noreply.github.com>
  • Loading branch information
mshatkhin23 authored Jan 5, 2024
1 parent 76660e7 commit ecd0c70
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/hera/workflows/workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -248,12 +248,12 @@ def _build_templates(self) -> Optional[List[TTemplate]]:
arguments: Annotated[
ArgumentsT,
_WorkflowModelMapper("spec.arguments", ArgumentsMixin._build_arguments),
]
] = None
metrics: Annotated[
MetricsT,
_WorkflowModelMapper("spec.metrics", MetricsMixin._build_metrics),
]
volumes: Annotated[VolumesT, _WorkflowModelMapper("spec.volumes", VolumeMixin._build_volumes)]
] = None
volumes: Annotated[VolumesT, _WorkflowModelMapper("spec.volumes", VolumeMixin._build_volumes)] = None

# Hera-specific fields
workflows_service: Optional[WorkflowsService] = None
Expand Down

0 comments on commit ecd0c70

Please sign in to comment.