Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvm install note to README #70

Merged

Conversation

shoenseiwaso
Copy link
Contributor

Update the README with a simple check to ensure the correct node version is installed.

The .nvmrc file specifies node version 10.12.0, and indeed, npm install will fail on the scrypt package with node 12.16.0 (probably others - see this issue for more context).

Copy link
Contributor

@elenadimitrova elenadimitrova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting! Please rebase so we can merge.

@shoenseiwaso
Copy link
Contributor Author

Thanks @elenadimitrova, rebased!

@elenadimitrova elenadimitrova merged commit d2c23ae into argentlabs:develop Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants