Preparing for Release v0.1.0 #18
Conversation
abachma2
added
Comp:Core
There was a problem hiding this comment.
I think you've covered the major points of the release. One thing you'll need to do is also tag the release (look up git tags in the git-scm documentation) at the commit that changes the version number. A tag is a special identifier that is useful for releases.
Do you plan to distribute the software (like on pypi ? )? That's another release step you may want to consider.
LICENSE
Outdated
| @@ -0,0 +1,29 @@ | |||
| BSD 3-Clause License | |||
|
|
|||
| Copyright (c) 2017, ERGS | |||
There was a problem hiding this comment.
I think the copyright line should be different here. The license should be attributed to ARFC or you. What is ERGS?
There was a problem hiding this comment.
I'll look at the other licenses in the group repository, but I got this from the d3ploy repo. So we might want to revisit that one too.
There was a problem hiding this comment.
I'll look at the other licenses in the group repository, but I got this from the d3ploy repo. So we might want to revisit that one too.
There was a problem hiding this comment.
Updated the name, but we should also update the d3ploy license.
setup.py
Outdated
| @@ -2,7 +2,7 @@ | |||
| from distutils.core import setup | |||
|
|
|||
|
|
|||
| VERSION = '0.0.1' | |||
| VERSION = '1.0.0' | |||
There was a problem hiding this comment.
How do you feel about doing a minor release instead of a major one (i.e. 0.1.0) -- that way you don't imply stability yet (usually the first major release means it is stable), but it is major enough for distribution.
There was a problem hiding this comment.
That's probably a really good idea. I'll update the number.
|
I don't plan on doing a pypi release or anything. Just have this housed here and create a zenodo object for it. |
Change year and name for license.
|
The changes in the code look good, but do you know why the tests are failing? |
|
The integration tests are failing because of a seg fault (Issue #12), but the unit tests all pass locally. The CI tests need to bu updated to show the unit tests working, likely having separate jobs to run the integration and unit tests. |
|
Ok that sounds good. In a separate conversation Amanda and I discussed fixing this for a future release, but this isn't blocking for this PR. |
This PR includes any final changes needed to create a release of v1.0.0. Right now, this is:
setup.pyfileIs there anything else needed to create a release?