more resilient power faliure under flash write

[hhaim]

No description provided.

[arendst]

Thx.

What you might know this crc thing is only available since version 6. Before there was no crc and only the cfg_holder was kind of indication for valid flash.

To make it possible for pre-version 6 users to migrate there were some tricks needed to make it possible.

With that info in mind you understand that just looking for a valid crc does solve your issue but raises problems for the migrants.

I'll look at your solution and see how it fits the migrants.

[hhaim]

I don’t see the issue, crc is checked only for newer versions. Even for flash from older Versions. the best sector (without crc) will be chosen.

On Tue, 29 Jan 2019 at 23:43 Theo Arends ***@***.***> wrote: Thx. What you might know this crc thing is only available since version 6. Before there was no crc and only the cfg_holder was kind of indication for valid flash. To make it possible for pre-version 6 users to migrate there were some tricks needed to make it possible. With that info in mind you understand that just looking for a valid crc does solve your issue but raises problems for the migrants. I'll look at your solution and see how it fits the migrants. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5065 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMbjvbcvMG4IdLSGaw2aJhUQeYPURkhIks5vIMB2gaJpZM4aY5kA> .

-- Hanoh Sent from my iPhone

[andrethomas]

In addition to @arendst concerns about migrating users this is a serious concern for me... making a PR which has not been tested.

You need to understand that we also have many users running open development binaries (some because they always hunt the new features, some because they are continiously testing and others because open development binaries are the only way to solve a current issue that has been fixed since the last release.)

So you'll need to define some form of scientific reproducible way to prove which scenario's this PR is actually good for as merging an untested or unproven PR could have catastrophic implications for such users.

[arendst]

And I did it my way again.