Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use RESET_N pin #550

Merged
merged 3 commits into from
Jul 23, 2020
Merged

Don't use RESET_N pin #550

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20cfad1
Don't use RESET_N pin
janakelarsson Jun 5, 2020
4aad6ad
Merge pull request #1 from arduino/master
janakelarsson Jul 23, 2020
a4dba62
Merge pull request #2 from janakelarsson/master
janakelarsson Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions variants/mkrnb1500/variant.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,10 @@ void initVariant() {
pinMode(SARA_PWR_ON, OUTPUT);
digitalWrite(SARA_PWR_ON, LOW);

// put SARA modem in reset on start to conserve power if it's not used
// data sheet discourages use of SARA modem reset pin
// use may lead to irrecoverable state of modem
pinMode(SARA_RESETN, OUTPUT);
digitalWrite(SARA_RESETN, HIGH);
digitalWrite(SARA_RESETN, LOW);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @janakelarsson 👋 This line is already in ArduinoCore-samd:master:HEAD - please rebase your commit.

Copy link
Contributor Author

@janakelarsson janakelarsson Jul 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aentinger Better now (I don't have a local copy of the git archive for that small change so I mistakenly thought the green light meant the PR was OK)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or do I need to squash the commits?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good now, I'll squash them myself.


// set RTS to LOW
pinMode(SARA_RTS, OUTPUT);
Expand Down