Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add begin() guard #31

Merged
merged 6 commits into from
May 22, 2024
Merged

Add begin() guard #31

merged 6 commits into from
May 22, 2024

Conversation

sebromero
Copy link
Contributor

This PR adds a guard to make begin() idempotent. Along with that the PR fixes a few warnings and adds additional error handling.

@sebromero sebromero requested a review from aentinger May 16, 2024 07:29
Copy link

Memory usage change @ e95199c

Board flash % RAM for global variables %
arduino:mbed_nicla:nicla_vision 🔺 +112 - +112 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 +216 - +216 +0.01 - +0.01 🔺 +4 - +4 0.0 - 0.0
Click for full report table
Board examples/BasicUsage
flash
% examples/BasicUsage
RAM for global variables
% examples/ReadWriteRegs
flash
% examples/ReadWriteRegs
RAM for global variables
%
arduino:mbed_nicla:nicla_vision 112 0.01 0 0.0 112 0.01 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7:target_core=cm4 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 216 0.01 4 0.0 216 0.01 4 0.0
Click for full report CSV
Board,examples/BasicUsage<br>flash,%,examples/BasicUsage<br>RAM for global variables,%,examples/ReadWriteRegs<br>flash,%,examples/ReadWriteRegs<br>RAM for global variables,%
arduino:mbed_nicla:nicla_vision,112,0.01,0,0.0,112,0.01,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7:target_core=cm4,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,216,0.01,4,0.0,216,0.01,4,0.0

@per1234 per1234 added the topic: code Related to content of the project itself label May 16, 2024
Copy link
Collaborator

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sebromero sebromero merged commit 1f4c1ca into master May 22, 2024
13 checks passed
@sebromero sebromero deleted the idempotence branch May 22, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants