Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump cosmos-sdk to v0.47 #442

Merged
merged 28 commits into from
Oct 13, 2023
Merged

feat: bump cosmos-sdk to v0.47 #442

merged 28 commits into from
Oct 13, 2023

Conversation

* replacing tendermint refs with comet bft

* replacing tm-db with cometbft-db
* bumping sdk and wasmd and ibc versions

* bumping ibc-go refs
* protobuf migration

* removing third_party/

* regenerating the proto files

* RecordIDs.Ids is a repeated non-nullable native type, nullable=false has no effect
@spoo-bar spoo-bar marked this pull request as ready for review September 4, 2023 06:02
@spoo-bar spoo-bar requested a review from a team as a code owner September 4, 2023 06:02
@spoo-bar spoo-bar marked this pull request as draft September 4, 2023 06:03
spoo-bar and others added 19 commits September 4, 2023 11:33
updating upstream references for x/wasm. ibc-go, cosmos-sdk
* remove genmsg deprecated route

* remove rewards module deprecated route

* remove tracking module deprecated route
* fixing x/tracking module

* fixing x/rewards module

* fixing x/genmsg module

* fixing genmsg module.go

* fixing wasmbinding
* fixing the upgrade handlers

* fixing ante.go

* fixing export.go

* updating sim_test

* fixing test_helpers

* fixing some app.go stuff

* custom "add-genesis-account" - removed as its not needed anymore

* fixing root.go

* fixing simulation test

* fixing app.go

* cleanup
* fixing some e2e tests

* fix more e2e tests

* fixing ibc e2e stuff

* updating changes from merge

* fixing golang.org/x/exp ref. thx @fdymylja

Co-Authored-By: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>

* pr comment fixes

---------

Co-authored-by: Frojdi Dymylja <33157909+fdymylja@users.noreply.github.com>
* adding posthandler and reflection services

* updating `sdkerrors.Wrap` with `errorsmod`

* every cosmos message protobuf definition must be extended with a cosmos.msg.v1.signer option to signal the signer fields

* better error for when post handler fails

* running go mod tidy

* registering query server after module init

---------

Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>
Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>
* adding crisis module store key

* adding crisis module

* adding consensus module

* adding group module

* adding nft module

* fixing the merge

* fixing gentx decoding

* adding consensusparamtypes.StoreKey storekey && fixing staking keeper

---------

Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>
* updating to wasmd fork 0.42.0

* adding capability cosmwasm_1_4

* updating v1.4 libwasmvm checksums
* fixing lint issues

* fixing x/tracking tests

* fixing app_test.go

* replacing gov v1beta1 stuff with gov v1

* fixig app-upgrade-test

txRes.Data is deprecated in favour of txRes.MsgResponses

* removing depracated field usage

* fixing ibctm not setup

* making the flat fees e2e test simpler

* fixing interchaintest chain upgrade

* fixing TestTxFees thanks @fdymylja 🎉

* fixing more tests with initgenesis failure

* fixing testcase to be compatible with this change cosmos/cosmos-sdk#9651

* removing the ante.DeductFeeDecorator as we alreayd have a custom one

* fixing TestRewardsFlatFees

* undo the mintkeeper fix
* adding missing consensus keeper

* adding upgrade handler stuff

* oops messed the merge. fixing that

---------

Signed-off-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>
* handling behavior change in infinitegasmeter.Limit()

* reflect no mo
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 115 lines in your changes are missing coverage. Please review.

Comparison is base (2be1f72) 69.54% compared to head (37dec9b) 69.28%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
- Coverage   69.54%   69.28%   -0.26%     
==========================================
  Files          68       70       +2     
  Lines        4025     4145     +120     
==========================================
+ Hits         2799     2872      +73     
- Misses       1128     1169      +41     
- Partials       98      104       +6     
Files Coverage Δ
app/genesis.go 100.00% <100.00%> (ø)
wasmbinding/query_plugin.go 78.37% <100.00%> (ø)
x/genmsg/genesis.go 68.75% <100.00%> (ø)
x/rewards/keeper/distribution.go 95.06% <100.00%> (ø)
x/rewards/keeper/flat_fee.go 77.77% <100.00%> (ø)
x/rewards/keeper/metadata.go 94.91% <100.00%> (ø)
x/rewards/keeper/min_cons_fee.go 69.81% <100.00%> (+0.58%) ⬆️
x/rewards/keeper/state.go 100.00% <100.00%> (ø)
x/rewards/keeper/tracking.go 100.00% <100.00%> (ø)
x/rewards/types/metadata.go 43.33% <100.00%> (ø)
... and 25 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* adding new msg proto

* implementing UpdateParams msg

* adding tests

* adding module migrations forx/rewards

* adding x/rewards to upgrade handlers

* adding migratestore test

* fixing lint

* addressing pr review comments
* bumping wasmd fork to to v0.43.0

* updating wasmvm checksum

* removing wasmd deprecated proposals as they arent in the codebase anymore

* Updating changelog
fixing ibc conformance test. the custom genesis values are needed just for upgrade test
@spoo-bar spoo-bar marked this pull request as ready for review October 11, 2023 09:09
@spoo-bar spoo-bar requested a review from a team as a code owner October 11, 2023 09:09
@spoo-bar spoo-bar requested review from shahbazn, fdymylja and zanicar and removed request for loverdos October 11, 2023 09:09
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Mammoth task... well done!

Copy link
Contributor

@shahbazn shahbazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only reviewed the Dockerfile.deprecated. lgtm!

Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spoo-bar spoo-bar merged commit 9c91298 into main Oct 13, 2023
10 checks passed
@spoo-bar spoo-bar deleted the feat/sdk-47-upgrade branch October 13, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants