Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4302 edit nodes containing data #4476

Merged
merged 4 commits into from
Jan 28, 2019
Merged

Conversation

veuncent
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Allows editing nodegroups that contain data.

Issues Solved

This code has gone awol since it was first implemented in Arches 4.1.
Adding it again after consulting @chiatt

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

arches/app/models/graph.py Outdated Show resolved Hide resolved
arches/app/models/graph.py Outdated Show resolved Hide resolved
arches/app/views/graph.py Outdated Show resolved Hide resolved
arches/app/views/graph.py Outdated Show resolved Hide resolved
arches/app/views/graph.py Outdated Show resolved Hide resolved
@veuncent veuncent requested a review from chiatt January 27, 2019 19:32
@veuncent veuncent self-assigned this Jan 27, 2019
@coveralls
Copy link

coveralls commented Jan 27, 2019

Coverage Status

Coverage decreased (-0.002%) to 40.504% when pulling 6689883 on 4302-edit-nodes-containing-data into bd5dfec on master.

@chiatt
Copy link
Member

chiatt commented Jan 28, 2019

Works as expected. Thanks @veuncent!

@chiatt chiatt merged commit 829076b into master Jan 28, 2019
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@chiatt chiatt deleted the 4302-edit-nodes-containing-data branch December 4, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants