Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '@' from scoped package names #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skoging
Copy link

@skoging skoging commented Aug 13, 2020

Fixes #7

The name of scoped packages "@scope/package" are currently transformed to "@types/@scope__package".

/ is handled correctly, but not @.

The name of scoped packages `"@scope/package"` are currently transformed to `"@types/@scope__package"`.

`/` is handled correctly, but not `@`.
@gausie
Copy link

gausie commented Apr 30, 2021

In lieu of this being merged, I've added

 "resolutions": {
    "ts-pnp": "patch:ts-pnp@^1.2.0#fix-scoped-packages-in-ts-pnp.diff"
  },

to my package.json

With the diff file being the patch from this PR. Thanks @skoging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolving @types package for scoped packages: error TS7016
2 participants