-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sherlock workflow fails when no JS code block is present #8
Comments
The reason for that is that we need to "cancel" the subsequent job steps when there's no code, but GitHub doesn't support neutral exit code or similar feature (to the best of my knowledge?). |
Oh, I usually do that by setting an output on the step that determines whether to continue, and then something like |
That seems a good idea - is that something you could PR in our workflow? This part of the integration isn't stored in this repository 🤔 |
Sure, I'll try to do that this weekend, both in the readme here and in the
real workflow in the Berry repo.
Some implementation questions before I start on that:
The easy solution here is to just skip subsequent steps when the "payload"
step fails, but that might hide other, unexpected, types of failure that we
probably don't want to hide (?).
A better approach would be to check the output and only skip subsequent
steps if the specific failure type was this "no JS code block found" case.
Does the sherlock script output a specific exit code for that, or would I
have to parse the text output?
Or, maybe just go ahead and add that exit code if it doesn't already have
it?
…On Thu, Feb 25, 2021, 10:30 Maël Nison ***@***.***> wrote:
That seems a good idea - is that something you could PR in our workflow
<https://github.com/yarnpkg/berry/blob/master/.github/workflows/sherlock-workflow.yml>?
This part of the integration isn't stored in this repository 🤔
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKCLJJIOYAJA4CVUIR7UITTA2JMVANCNFSM4YF6JPPA>
.
|
I just opened an issue over at yarnpkg/berry#2517 and got a bunch of emails telling me "Run failed: Sherlock for Yarn". Looking at the actual run, the error appears to be because "no JS code block got found". https://github.com/yarnpkg/berry/runs/1976830896?check_suite_focus=true#step:5:172. I assume this workflow should simply be a no-op when no JS test case is present in the issue instead of failing a bunch?
The text was updated successfully, but these errors were encountered: