GT-330 Remove netgo build tag for Windows to disable new Go resolver behaviour
#352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iour In go1.19 there is no support for 'hosts' file for Windows: golang/go#57757 Disabling netgo will revert behaviour to go1.18 for resolving names
ajanikow
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In go1.19 there is no support for 'hosts' file for Windows:
golang/go#57757
Disabling netgo will revert behaviour to go1.18 for resolving names.
Fixes
Failed to connect to master error="Get \"http://localhost:9528/hello\": dial tcp: lookup localhost on 10.156.0.1:53: no such host"error