Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flag): incorrect behavior for deprected flag --clear-cache #7281

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

afdesk
Copy link
Contributor

@afdesk afdesk commented Jul 31, 2024

Description

ClearCache should be initialized for correct message.

Before:

$ trivy image --clear-cache
Scan a container image
...
2024-07-31T18:13:26+06:00	FATAL	Fatal error	unknown flag: --clear-cache

After:

$ trivy image --clear-cache
2024-07-31T18:14:29+06:00	ERROR	"--clear-cache" was removed. Use "trivy clean --scan-cache" instead
2024-07-31T18:14:29+06:00	FATAL	Fatal error	flag error: cache flag error: unable to parse flag: removed flag ("--clear-cache")

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@afdesk afdesk mentioned this pull request Jul 31, 2024
6 tasks
@afdesk afdesk marked this pull request as ready for review July 31, 2024 12:41
@afdesk afdesk requested a review from knqyf263 as a code owner July 31, 2024 12:41
@afdesk
Copy link
Contributor Author

afdesk commented Jul 31, 2024

@knqyf263 @DmitriyLewen could you take a look at this small fix? thanks

@knqyf263 knqyf263 added this pull request to the merge queue Jul 31, 2024
Merged via the queue into aquasecurity:main with commit 2a0e529 Jul 31, 2024
15 checks passed
@knqyf263
Copy link
Collaborator

@aqua-bot backport release/v0.54

@aqua-bot
Copy link
Contributor

Backport PR created: #7285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants