-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(db): change argument order in Exists query for JavaDB #4595
Conversation
|
@DaspawnW thanks for your PR! it looks like a curious mistake. |
but I can't find a case where this mistake matters. |
Hi @afdesk, I guess it's more a matter of performance. The Exists query gets called within the aquasecurity/go-dep-parser So it will work but has to perform for each dependency a second query even though it's available. |
it seems i understood what happens: |
Hi @DaspawnW |
@DaspawnW I've created an issue from your discussion - it's our workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the good catch!
Description
Related issues
Checklist