[TS SDK] Explore http2 #7432
Closed
[TS SDK] Explore http2 #7432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
reviewed
Mar 29, 2023
| exit(0); | ||
| } | ||
|
|
||
| async function transafer(sender: AptosAccount, recipient: string, sequenceNumber: bigint, amount: number) { |
There was a problem hiding this comment.
transfer or tran safer? 😂
Comment on lines
+106
to
+142
| "0x1::coin", | ||
| "transfer", |
There was a problem hiding this comment.
fyi, for future ease of use: 0x1::aptos_account::transfer_coins will create the account / register the coin if it doesn't exist
0xmigo
approved these changes
May 11, 2023
| accounts.push(new AptosAccount()); | ||
| recipients.push(new AptosAccount()); | ||
| } | ||
| console.log(`${accounts.length * 2} accounts created`); |
There was a problem hiding this comment.
Suggested change
| console.log(`${accounts.length * 2} accounts created`); | |
| console.log(`${accounts.length + recipients.length} accounts created`); |
nit: Number still the same, but i felt like its more read-able this way :D
| fetch(fund, { | ||
| method: "POST", | ||
| headers: { | ||
| Authorization: `Bearer ejfklsdfj7vr4388fhhfh3f78hf345345hf00da0`, |
There was a problem hiding this comment.
Curious, what is this bearer token here?
Comment on lines
+164
to
+165
| // const txn = await submitTransaction(bcsTxn); | ||
| // return txn.hash; |
There was a problem hiding this comment.
nit: Forgot to remove these 2 lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explore http2 using fetch-h2 package.
Notes:
axiosbut it doesnt support http2.waitFoTransactionwith this new client.Maximum call stack size exceeded- seems like a known issue RangeError: Maximum call stack size exceeded grantila/fetch-h2#93. Also checked the same process on the low-level http2 node module (what fetch-h2 is based on) and getting aStream closed with error code NGHTTP2_REFUSED_STREAMerror although they claim they fixed it HTTP/2 requests eventually start throwing NGHTTP2_ENHANCE_YOUR_CALM errors nodejs/node#27416https://explorer.aptoslabs.com/account/0x2230fa1a57bf2a1a1e22dcdcd9ef5ce99a0330d5bdb470fc6bc7b4d923d07175
https://explorer.aptoslabs.com/account/0xaad9a573b24d805fe9faa7b29e4c74ce50fe0a48346ce43c35152841faf41abb
https://explorer.aptoslabs.com/account/0x8e61b5b6d0cf993f37050c1c7a77dde01c0c845231db1521f57e66942a537e1b
https://explorer.aptoslabs.com/account/0x89f548868fae1ca803776c85d37b29cfa6b5ab722d5364f02cf3f30ee6e6edfe
All end up with sequence number = 99 - which makes sense since we submitted 100 txns per account.
Thank you David for code inspiration.