Add additional guards in tests for mocking #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In apple#2615 some of the syscall tests use a mocking infrastrucutre which is compiled out in release builds. The tests weren't correctly guarded for this so fail to build in release mode. Modifications: - Add missing guards - Add missing availability on tests Result: Tests compile in release mode
glbrntt
force-pushed
the
enable-mocking
branch
from
59f242f
to
84f370b
Compare
simonjbeaumont
approved these changes
Jan 16, 2024
FranzBusch
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In #2615 some of the syscall tests use a mocking infrastrucutre which is compiled out in release builds. The tests weren't correctly guarded for this so fail to build in release mode.
Modifications:
Result:
Tests compile in release mode