Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add canImport(_Concurrency) for Xcode 13.0 #2015

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Add canImport(_Concurrency) for Xcode 13.0 #2015

merged 1 commit into from
Dec 20, 2021

Conversation

fabianfett
Copy link
Member

Xcode 13.0 lacked concurrency support for macOS. We need to make sure we only use _Concurrency features, if the platform supports them.

Modifications:

  • Add canImport(_Concurrency) for Xcode 13.0 in AsyncAwaitSupport+OldXcodes.swift

Result:

Users can compile for macOS with Xcode 13.0.

@fabianfett fabianfett added the semver/patch No public API change. label Dec 20, 2021
Jomy10
Jomy10 approved these changes Dec 20, 2021
View reviewed changes
Copy link

@Jomy10 Jomy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed fixes the issue

@glbrntt glbrntt merged commit e123c21 into apple:main Dec 20, 2021
@fabianfett fabianfett deleted the ff-fix-compiler-error-for-xcode13.0 branch December 20, 2021 16:07
@0xTim 0xTim mentioned this pull request Dec 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

@Jomy10 Jomy10 Jomy10 approved these changes

Assignees
No one assigned
Labels
semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianfett @glbrntt @Jomy10