-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conform EventLoopFuture/Promise to Sendable #1982
Conversation
I'm afraid we will need to do this dance to make 5.2 - 5.4 happy: #if swift(>=5.5)
public typealias NIOSendable = Swift.Sendable
#else
public typealias NIOSendable = Any
#endif Then NIO types need to conform to |
Yeah forgot about that. I have duplicated the code from the original PR, which adds the conformance in a separate extension but yeah maybe implementing |
I think we should do |
We'll still have to stick |
Nah, it'll have to go into |
AsyncAwaitSupport.swift is in NIOCore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Conform
EventLoopFuture
andEventLoopPromise
toSendable
Motivation:
Fixes compile warnings
Based off discussion in #1928