Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_NIOConcurrency: Rename completeWithAsync(_:) to completeWithTask(_:) and return task #1911

Merged
merged 6 commits into from
Aug 3, 2021
Merged

_NIOConcurrency: Rename completeWithAsync(_:) to completeWithTask(_:) and return task #1911

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8b78232
_NIOConcurrency: Return Task from EventLoopPromise.completeWithAsync(_:)
simonjbeaumont Jul 22, 2021
ab3856f
Merge branch 'main' into complete-with-async-task
glbrntt Jul 22, 2021
4817ea1
_NIOConcurrency: Rename EventLoopPromise.completeWithAsync(_:) to com…
simonjbeaumont Jul 26, 2021
2e150d7
Merge branch 'main' into complete-with-async-task
glbrntt Jul 27, 2021
f8ebd60
Merge branch 'main' into complete-with-async-task
glbrntt Aug 2, 2021
0a284f7
Merge branch 'main' into complete-with-async-task
glbrntt Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/_NIOConcurrency/AsyncAwaitSupport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,11 @@ extension EventLoopPromise {
///
/// - parameters:
/// - body: The `async` function to run.
/// - returns: A `Task` which was created to `await` the `body`.
@available(macOS 12, iOS 15, tvOS 15, watchOS 8, *)
@discardableResult
@inlinable
public func completeWithAsync(_ body: @escaping () async throws -> Value) {
public func completeWithTask(_ body: @escaping () async throws -> Value) -> Task<Void, Never> {
glbrntt marked this conversation as resolved.
Show resolved Hide resolved
Task {
do {
let value = try await body()
Expand Down