Refactored SelectionSet::split_top_level_fields
#6123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
SelectionSet::split_top_level_fields
away from usingBox<dyn Iterator>
s. While not a performance issue (the function is called from exactly one place), it was a very smelly implementation, which required every item to be to be allocated in its own allocation before being yielded by the iterator.Since the iterator is recursive, I had to just implement
Iterator
on an internal type rather than use the opaque type (which can't be recursive at all) returned by the function.Lastly, I saw a couple of other
Box<dyn Iterator>
s that that could be turned into RPITs by using theEither
type from theeither
trait.either
is already a transitive dependency, so it adds no extra dependencies to theapollo-federation
orapollo-router
.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩