Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to reference elements further up the call chain as named parameters #2988

Merged
merged 85 commits into from
May 14, 2024
Merged

Add the ability to reference elements further up the call chain as named parameters #2988

merged 85 commits into from
May 14, 2024

Commits on Jan 31, 2024

  1. Some work on setContext. Mostly defining the directives and changes t… 

    …o the join spec.
    @clenfest
    clenfest committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    884befc View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. First pass at context validation. This will become obsolete since we … 

    …are going to do subgraph validation rather than supergraph, but I wanted to get it checked in before I start on the next phase.
    @clenfest
    clenfest committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    4561844 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Finished validation of contexts and making sure extractSubgraphsFromS… 

    …upergraph works
    @clenfest
    clenfest committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    b85d78a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into clenfest/setContext

    @clenfest
    clenfest committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    346fe3d View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Bump join spec and federation spec

    @clenfest
    clenfest committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d5117f3 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. checkpoint 

    more updates
    @clenfest
    clenfest committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    672b705 View commit details
    Browse the repository at this point in the history

  2. fix a couple of tests

    @clenfest
    clenfest committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    1f495a6 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Change from uuid for generation to something that is more gql friendl… 

    …y (nanoid). Also modify triggers to include contextual arguments when we reach leaf fields.
    @clenfest
    clenfest committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4ed6fdc View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Add inputRewrites for contextual values

    @clenfest
    clenfest committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    dffd92d View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Make context variable definition deterministic rather than random

    @clenfest
    clenfest committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b2bf2b6 View commit details
    Browse the repository at this point in the history

  2. fixed up tests with a todo

    @clenfest
    clenfest committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    1bc21d1 View commit details
    Browse the repository at this point in the history

  3. Fix up spelling and formatting

    @clenfest
    clenfest committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ed116b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Treat argument to contextual fields as a variable rather than a string

    @clenfest
    clenfest committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    e6503b5 View commit details
    Browse the repository at this point in the history

  2. typo

    @clenfest
    clenfest committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7af5952 View commit details
    Browse the repository at this point in the history

  3. test

    @clenfest
    clenfest committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    86b9120 View commit details
    Browse the repository at this point in the history

  4. testing in codesandbox, ignore this commit

    @clenfest
    clenfest committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0ba353b View commit details
    Browse the repository at this point in the history

  5. trying to use a key renamer instead of a value setter

    @clenfest
    clenfest committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    b8e9085 View commit details
    Browse the repository at this point in the history

  6. Realized that although I do want behavior very much like a inputRewri… 

    …tes, I don't want to use that exactly since it's tied to a requires selection set. Made a new array on FetchNode to rewrite context values. Also note that '..' has a valid meaning to go up a level in the path.
    @clenfest
    clenfest committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    411875a View commit details
    Browse the repository at this point in the history

  7. Use generated context id rather than paramter name for context_rewrites

    @clenfest
    clenfest committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    84c53ef View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. push an empty commit because package query-graphs wasnt published in … 

    …csb...
    @o0Ignition0o
    o0Ignition0o committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ba7b85d View commit details
    Browse the repository at this point in the history

  2. Use argument type in validation rather than hardcoded String

    @clenfest
    clenfest committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    cff5f8d View commit details
    Browse the repository at this point in the history

  3. Add typename to query plan

    @clenfest
    clenfest committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e692a81 View commit details
    Browse the repository at this point in the history

  4. fix bug in copyInputsOf

    @clenfest
    clenfest committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    509674d View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Merge branch 'main' into clenfest/setContext-qp

    @o0Ignition0o
    o0Ignition0o committed May 5, 2024
    Configuration menu
    Copy the full SHA
    5aef7f3 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. address comment

    @clenfest
    clenfest committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e30ff81 View commit details
    Browse the repository at this point in the history

  2. more changes

    @clenfest
    clenfest committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3d35225 View commit details
    Browse the repository at this point in the history

  3. updating regex

    @clenfest
    clenfest committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d370f20 View commit details
    Browse the repository at this point in the history

  4. get rid of canFulfillType to make more standard

    @clenfest
    clenfest committed May 6, 2024
    Configuration menu
    Copy the full SHA
    52c043f View commit details
    Browse the repository at this point in the history

  5. update implementation

    @clenfest
    clenfest committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6514d0b View commit details
    Browse the repository at this point in the history

  6. Add tests for rejecting selection sets with aliases or directives in … 

    …field values
    @clenfest
    clenfest committed May 6, 2024
    Configuration menu
    Copy the full SHA
    9b45fe8 View commit details
    Browse the repository at this point in the history

  7. Add test for ensuring that no @interfaceObject type may be referenced… 

    … in a context
    @clenfest
    clenfest committed May 6, 2024
    Configuration menu
    Copy the full SHA
    881ae1a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. multiple paths

    @clenfest
    clenfest committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2890817 View commit details
    Browse the repository at this point in the history

  2. fix prettier and spelling

    @clenfest
    clenfest committed May 7, 2024
    Configuration menu
    Copy the full SHA
    9477fac View commit details
    Browse the repository at this point in the history

  3. Add ContextFieldValue scalar to subgraph schema.

    @clenfest
    clenfest committed May 7, 2024
    Configuration menu
    Copy the full SHA
    00fedbf View commit details
    Browse the repository at this point in the history

  4. delete dead code

    @clenfest
    clenfest committed May 7, 2024
    Configuration menu
    Copy the full SHA
    647a5a4 View commit details
    Browse the repository at this point in the history

  5. change logic of valid non-contextual arguments

    @clenfest
    clenfest committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f355e8b View commit details
    Browse the repository at this point in the history

  6. add more validation tests

    @clenfest
    clenfest committed May 7, 2024
    Configuration menu
    Copy the full SHA
    124760a View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. extractSubgraphFromSupergraph code review comments

    @clenfest
    clenfest committed May 8, 2024
    Configuration menu
    Copy the full SHA
    96b428e View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. code review updates

    @clenfest
    clenfest committed May 9, 2024
    Configuration menu
    Copy the full SHA
    34b2fff View commit details
    Browse the repository at this point in the history

  2. fixing up union types

    @clenfest
    clenfest committed May 9, 2024
    Configuration menu
    Copy the full SHA
    dcef412 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Add a union test into buildPlan. Also fixed up the logic that tests f… 

    …or whether a context rewrite exists before we add it.
    @clenfest
    clenfest committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9298a56 View commit details
    Browse the repository at this point in the history

  2. prettier

    @clenfest
    clenfest committed May 10, 2024
    Configuration menu
    Copy the full SHA
    87abc6f View commit details
    Browse the repository at this point in the history

  3. relative path should ignore FragmentElements

    @clenfest
    clenfest committed May 10, 2024
    Configuration menu
    Copy the full SHA
    9bdfd1f View commit details
    Browse the repository at this point in the history

  4. get rid of hack

    @clenfest
    clenfest committed May 10, 2024
    Configuration menu
    Copy the full SHA
    6976448 View commit details
    Browse the repository at this point in the history

  5. checkpoint

    @clenfest
    clenfest committed May 10, 2024
    Configuration menu
    Copy the full SHA
    7271c8b View commit details
    Browse the repository at this point in the history

  6. add optional validation

    @clenfest
    clenfest committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ea94a7e View commit details
    Browse the repository at this point in the history

  7. union types broken

    @clenfest
    clenfest committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ec73f62 View commit details
    Browse the repository at this point in the history

  8. Deal with @requires and @fromcontext in the same conditions

    @clenfest
    clenfest committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1f82cf3 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. fix FragmentSelection case (union)

    @clenfest
    clenfest committed May 11, 2024
    Configuration menu
    Copy the full SHA
    3b8f641 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2024

  1. delete dead code

    @clenfest
    clenfest committed May 12, 2024
    Configuration menu
    Copy the full SHA
    a6c9a03 View commit details
    Browse the repository at this point in the history

  2. code review updates

    @clenfest
    clenfest committed May 12, 2024
    Configuration menu
    Copy the full SHA
    7d561f6 View commit details
    Browse the repository at this point in the history

  3. updates

    @clenfest
    clenfest committed May 12, 2024
    Configuration menu
    Copy the full SHA
    b210b3b View commit details
    Browse the repository at this point in the history

  4. subgraph schema in toPlanNode()

    @clenfest
    clenfest committed May 12, 2024
    Configuration menu
    Copy the full SHA
    903436b View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Add contextsToConditionsGroups as a dedicated variable in the compute… 

    …GroupsForTree stack. This solves a couple problems we were seeing where duplicate values were being requested as well as removing the need for canSatisfyConditions to merge @requires and @fromcontext keys
    @clenfest
    clenfest committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c21a63a View commit details
    Browse the repository at this point in the history

  2. fix subgraph name transform

    @clenfest
    clenfest committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5ebddec View commit details
    Browse the repository at this point in the history

  3. Add test for and fixes the case where the fetchGroup where data is us… 

    …ed and where it is set are already different
    @clenfest
    clenfest committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3ba1b5d View commit details
    Browse the repository at this point in the history

  4. Add hint when removing an argument from the supergraph

    @clenfest
    clenfest committed May 13, 2024
    Configuration menu
    Copy the full SHA
    0a592ff View commit details
    Browse the repository at this point in the history

  5. remove some dead code

    @clenfest
    clenfest committed May 13, 2024
    Configuration menu
    Copy the full SHA
    eee34b5 View commit details
    Browse the repository at this point in the history

  6. move contextToSelection to Child from OpPathTree

    @clenfest
    clenfest committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b000806 View commit details
    Browse the repository at this point in the history

  7. Move parameterToContext onto child

    @clenfest
    clenfest committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3c44f7a View commit details
    Browse the repository at this point in the history

  8. fix spelling

    @clenfest
    clenfest committed May 13, 2024
    Configuration menu
    Copy the full SHA
    d90b818 View commit details
    Browse the repository at this point in the history

  9. update snapshots

    @clenfest
    clenfest committed May 13, 2024
    Configuration menu
    Copy the full SHA
    fcff867 View commit details
    Browse the repository at this point in the history

  10. Update loop detection in satisfiability checks

    @sachindshinde
    sachindshinde committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6eadd46 View commit details
    Browse the repository at this point in the history

  11. Update advancePathWithDirectTransition() error messaging to account f… 

    …or contexts not being set in the GraphPath
    @sachindshinde
    sachindshinde committed May 13, 2024
    Configuration menu
    Copy the full SHA
    fa91a78 View commit details
    Browse the repository at this point in the history

  12. Use camelCase instead of snake_case

    @sachindshinde
    sachindshinde committed May 13, 2024
    Configuration menu
    Copy the full SHA
    dcd870b View commit details
    Browse the repository at this point in the history

  13. Update validate() for arguments to check @fromcontext on subgraphs in… 

    …stead of @context in supergraphs
    @sachindshinde
    sachindshinde committed May 13, 2024
    Configuration menu
    Copy the full SHA
    5cd6477 View commit details
    Browse the repository at this point in the history

  14. Fix argument types in context spec

    @sachindshinde
    sachindshinde committed May 13, 2024
    Configuration menu
    Copy the full SHA
    8f0544e View commit details
    Browse the repository at this point in the history

  15. Update names, and remove dead code from specs files

    @sachindshinde
    sachindshinde committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4830903 View commit details
    Browse the repository at this point in the history

  16. Remove context spec from gateway supported features, and add list of … 

    …router supported features
    @sachindshinde
    sachindshinde committed May 13, 2024
    Configuration menu
    Copy the full SHA
    f7a35c0 View commit details
    Browse the repository at this point in the history

  17. Add function Supergraph.buildForTests() that will build using router … 

    …features
    @clenfest
    clenfest committed May 13, 2024
    Configuration menu
    Copy the full SHA
    cc55f8a View commit details
    Browse the repository at this point in the history

  18. Update subgraph validation to account for object type conditions

    @sachindshinde
    sachindshinde committed May 13, 2024
    Configuration menu
    Copy the full SHA
    c14a873 View commit details
    Browse the repository at this point in the history

  19. Translate subgraph names to GraphQL enum values using existing mapping

    @sachindshinde
    sachindshinde committed May 13, 2024
    Configuration menu
    Copy the full SHA
    cc6d499 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Update QueryGraph to have schema, and update option generation to par… 

    …se against supergraph schema
    @sachindshinde
    sachindshinde committed May 14, 2024
    Configuration menu
    Copy the full SHA
    3ccd70a View commit details
    Browse the repository at this point in the history

  2. Fix bug in parameter to context comparison

    @sachindshinde
    sachindshinde committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ac64973 View commit details
    Browse the repository at this point in the history

  3. Updated computeGroupsForTree() for context handling

    @sachindshinde
    sachindshinde committed May 14, 2024
    Configuration menu
    Copy the full SHA
    8acad3e View commit details
    Browse the repository at this point in the history

  4. update tests to use ofType and remove nonNullable from contextual arg… 

    …uments
    @clenfest
    clenfest committed May 14, 2024
    Configuration menu
    Copy the full SHA
    92bb1e8 View commit details
    Browse the repository at this point in the history

  5. Remove unused field in query plan

    @sachindshinde
    sachindshinde committed May 14, 2024
    Configuration menu
    Copy the full SHA
    1c0ab3d View commit details
    Browse the repository at this point in the history

  6. Fix bug where context additions happened at wrong location in compute… 

    …GroupsForTree()
    @sachindshinde
    sachindshinde committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0f09e7e View commit details
    Browse the repository at this point in the history

  7. Update composition validation to handle bad subgraph names

    @sachindshinde
    sachindshinde committed May 14, 2024
    Configuration menu
    Copy the full SHA
    2aa8f76 View commit details
    Browse the repository at this point in the history

  8. fixing up broken tests

    @clenfest
    clenfest committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c420486 View commit details
    Browse the repository at this point in the history

  9. fix spelling

    @clenfest
    clenfest committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f0f0ce7 View commit details
    Browse the repository at this point in the history

  10. add changeset

    @clenfest
    clenfest committed May 14, 2024
    Configuration menu
    Copy the full SHA
    cf64c4a View commit details
    Browse the repository at this point in the history

  11. Merge branch 'next' into clenfest/setContext-qp

    @clenfest
    clenfest committed May 14, 2024
    Configuration menu
    Copy the full SHA
    7ff75ab View commit details
    Browse the repository at this point in the history

  12. spelling

    @clenfest
    clenfest committed May 14, 2024
    Configuration menu
    Copy the full SHA
    d6f99b5 View commit details
    Browse the repository at this point in the history

  13. prettier fix

    @clenfest
    clenfest committed May 14, 2024
    Configuration menu
    Copy the full SHA
    dd72c8e View commit details
    Browse the repository at this point in the history