Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloud functions tests #1611

Closed

Conversation

reaktivo
Copy link
Contributor

@reaktivo reaktivo commented Sep 4, 2018

A few weeks ago the Google Cloud Functions implementation that I worked on was merged with tests that were never run. This was reported by @martijnwalraven here.

I've created this issue which moves tests to their correct location and fixes some edge cases that were caught by the integration test suite when actually run.

@martijnwalraven I've included your changes here, I hope you don't mind.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant