Skip to content

Commit

Permalink
get CI passing
Browse files Browse the repository at this point in the history
  • Loading branch information
trevor-scheer committed Aug 30, 2023
1 parent d38b43b commit 1dd45b8
Show file tree
Hide file tree
Showing 7 changed files with 222 additions and 140 deletions.
23 changes: 16 additions & 7 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,25 @@ commands:
# something different. Probably best to avoid that, out of principle, though.
common_node_steps:
description: "Set up Node.js environment and install dependencies"
parameters:
npm_version:
default: '8'
type: string
steps:
- oss/install_specific_npm_version:
version: '8'
version: <<parameters.npm_version>>
- checkout
- oss/npm_clean_install_with_caching

common_test_steps:
description: "Set up Node.js environment and run tests"
parameters:
npm_version:
default: '8'
type: string
steps:
- common_node_steps
- common_node_steps:
npm_version: <<parameters.npm_version>>
- run:
command: npm run test:ci
environment:
Expand All @@ -47,7 +56,8 @@ jobs:
docker:
- image: cimg/node:12.22.6
steps:
- common_test_steps
- common_test_steps:
npm_version: '6'
# We will save the results of this one particular invocation to use in
# the publish step. Not only does this make the publishing step take less
# time, this also ensures that a passing version gets deployed even if,
Expand All @@ -66,7 +76,7 @@ jobs:

NodeJS 16:
docker:
- image: cimg/node:16.10.0
- image: cimg/node:16.20
steps:
- common_test_steps

Expand All @@ -78,14 +88,14 @@ jobs:

Prettier:
docker:
- image: cimg/node:16.10.0
- image: cimg/node:16.20
steps:
- common_node_steps
- run: npm run prettier-check

Spell check:
docker:
- image: cimg/node:16.10.0
- image: cimg/node:16.20
steps:
- common_node_steps
- run: npm run spell-check
Expand Down Expand Up @@ -131,7 +141,6 @@ common_publish_filters: &common_publish_filters
ignore: /.*/

workflows:
version: 2
Build:
jobs:
- NodeJS 12:
Expand Down
1 change: 1 addition & 0 deletions cspell-dict.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ automerge
Automerge
automerges
backoff
barbaz
beyoncé
blahblah
Blocklist
Expand Down
Loading

0 comments on commit 1dd45b8

Please sign in to comment.