Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where multiple fetches might report data if result contained errors #11984

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

jerelmiller
Copy link
Member

Fixes #11938

Fixes an issue where multiple fetches might report data if the result from the request contained errors. This happened as a result of the logic that checks to see if the value we are emitting was from an old request. We set the data property on the value emitted from the observable, but we didn't check to see if we had errors or not. In some cases, the value would be reported with the data property set which could leak to the end result.

Copy link

changeset-bot bot commented Aug 1, 2024

🦋 Changeset detected

Latest commit: 22161f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 1, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 39.31 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.98 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 45.56 KB (+0.02% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.38 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.28 KB (+0.04% 🔺)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.21 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.3 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.69 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.77 KB (0%)
import { useMutation } from "dist/react/index.js" 3.62 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.84 KB (0%)
import { useSubscription } from "dist/react/index.js" 4.41 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 3.46 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.49 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.15 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.99 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.64 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.07 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.72 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.39 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.33 KB (0%)
import { useFragment } from "dist/react/index.js" 2.32 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.27 KB (0%)

@jerelmiller
Copy link
Member Author

/release:pr

Copy link
Contributor

github-actions bot commented Aug 1, 2024

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-11984-20240801210716

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit a41bd42
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/66b0e904691e850008ea8627
😎 Deploy Preview https://deploy-preview-11984--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this over a pairing session, LGTM 🚀

@jerelmiller jerelmiller merged commit 5db1659 into main Aug 5, 2024
42 checks passed
@jerelmiller jerelmiller deleted the jerel/issue-11938-reset-store-data branch August 5, 2024 17:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial data returned on error after resetting cache
2 participants