Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the description of the environment name #5082

Merged
merged 100 commits into from
Jan 25, 2024

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Jan 25, 2024

What's the purpose of this PR

This is an implicit logic within Apollo. If not described clearly, users will be very confused

  private static String getWellFormName(String envName) {
    if (StringUtils.isBlank(envName)) {
      return "";
    }

    String envWellFormName = envName.trim().toUpperCase();

    // special case for production in case of typo
    if ("PROD".equals(envWellFormName)) {
      return Env.PRO.name;
    }

    // special case that FAT & FWS should map to FAT
    if ("FWS".equals(envWellFormName)) {
      return Env.FAT.name;
    }

    return envWellFormName;
  }

klboke and others added 30 commits May 16, 2019 11:07
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff44245) 49.59% compared to head (b2caaff) 49.60%.
Report is 1 commits behind head on master.

❗ Current head b2caaff differs from pull request most recent head c8e190e. Consider uploading reports for the commit c8e190e to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5082   +/-   ##
=========================================
  Coverage     49.59%   49.60%           
- Complexity     1903     1904    +1     
=========================================
  Files           372      372           
  Lines         11564    11564           
  Branches       1127     1127           
=========================================
+ Hits           5735     5736    +1     
  Misses         5488     5488           
+ Partials        341      340    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 25, 2024
@nobodyiam nobodyiam merged commit 73b4b84 into apolloconfig:master Jan 25, 2024
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@nobodyiam nobodyiam added this to the 2.3.0 milestone Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants