feat(openapi): allow user create app via openapi #4954

Anilople · 2023-08-11T12:21:12Z

What's the purpose of this PR

Allow user create app via openapi

Which issue(s) this PR fixes:

#4234

Dependency on apolloconfig/apollo-java#32

Brief changelog

Bind consumer to a role which can create app.

Just a poc code, please don't merge.

Follow this checklist to help us incorporate your contribution quickly and easily:

Read the Contributing Guide before making this pull request.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit tests to verify the code.
Run mvn clean test to make sure this pull request doesn't break anything.
Update the CHANGES log.

apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi/service/ConsumerService.java

...src/main/java/com/ctrip/framework/apollo/openapi/server/service/ServerAppOpenApiService.java

apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi/service/ConsumerService.java

…/server/service/ServerAppOpenApiService.java Co-authored-by: Jason Song <nobodyiam@gmail.com>

….com/Anilople/apollo into feat/portal-allow-openapi-create-app

apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/AppService.java

Anilople · 2023-08-16T14:38:19Z

Will add some tests later

apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/AppController.java

...src/main/java/com/ctrip/framework/apollo/openapi/server/service/ServerAppOpenApiService.java

apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/AppService.java

apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/AppController.java

codecov · 2023-09-01T00:16:53Z

Codecov Report

Merging #4954 (075c7a4) into master (84c1d0b) will increase coverage by 0.48%.
The diff coverage is 57.89%.

@@             Coverage Diff              @@
##             master    #4954      +/-   ##
============================================
+ Coverage     48.48%   48.96%   +0.48%     
- Complexity     1726     1781      +55     
============================================
  Files           346      348       +2     
  Lines         10836    10991     +155     
  Branches       1080     1095      +15     
============================================
+ Hits           5254     5382     +128     
- Misses         5258     5279      +21     
- Partials        324      330       +6

Files Changed	Coverage Δ
...k/apollo/common/exception/BadRequestException.java	`85.71% <0.00%> (-14.29%)`	⬇️
...ollo/openapi/auth/ConsumerPermissionValidator.java	`25.00% <0.00%> (-2.78%)`	⬇️
...penapi/server/service/ServerAppOpenApiService.java	`22.58% <0.00%> (-12.42%)`	⬇️
...rk/apollo/openapi/v1/controller/AppController.java	`36.36% <0.00%> (-30.31%)`	⬇️
...mework/apollo/portal/controller/AppController.java	`29.33% <0.00%> (+2.50%)`	⬆️
...mework/apollo/openapi/service/ConsumerService.java	`56.84% <50.00%> (-1.62%)`	⬇️
...k/apollo/portal/controller/ConsumerController.java	`43.85% <76.92%> (+33.33%)`	⬆️
...apollo/portal/entity/vo/consumer/ConsumerInfo.java	`82.14% <82.14%> (ø)`
...ip/framework/apollo/portal/service/AppService.java	`39.56% <88.88%> (+23.89%)`	⬆️
...al/entity/vo/consumer/ConsumerCreateRequestVO.java	`89.47% <89.47%> (ø)`
... and 1 more

... and 3 files with indirect coverage changes

...lo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/ConsumerController.java

...-portal/src/main/java/com/ctrip/framework/apollo/portal/entity/vo/consumer/ConsumerInfo.java

apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/AppController.java

...lo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/ConsumerController.java

apollo-portal/src/main/resources/static/i18n/en.json

apollo-portal/src/main/resources/static/open/manage.html

…/v1/controller/AppController.java Co-authored-by: Jason Song <nobodyiam@gmail.com>

Co-authored-by: Jason Song <nobodyiam@gmail.com>

…controller/ConsumerController.java Co-authored-by: Jason Song <nobodyiam@gmail.com>

Co-authored-by: Jason Song <nobodyiam@gmail.com>

apollo-portal/src/main/resources/static/open/add-consumer.html

nobodyiam · 2023-09-18T11:59:54Z

Looks great! One minor suggestion: consider removing the * before the Allow app creation? label since the default setting for this field is false.

nobodyiam · 2023-09-19T12:17:16Z

BTW, please also help to update the CHANGES.md.

Anilople · 2023-09-19T13:22:29Z

Looks great! One minor suggestion: consider removing the * before the Allow app creation? label since the default setting for this field is false.

Done in 20a860f

Anilople · 2023-09-19T13:23:37Z

BTW, please also help to update the CHANGES.md.

Done in 075c7a4

nobodyiam

LGTM

nobodyiam · 2023-12-03T06:00:32Z

@Anilople it appears that the documentation for the new API is not included. Could you kindly assist in incorporating it into the documentation?

feat(openapi): allow user create app via openapi

06b2643

Anilople commented Aug 11, 2023

View reviewed changes

apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi/service/ConsumerService.java Outdated Show resolved Hide resolved

nobodyiam reviewed Aug 12, 2023

View reviewed changes

Anilople and others added 3 commits August 12, 2023 22:38

Update apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi…

6e510c0

…/server/service/ServerAppOpenApiService.java Co-authored-by: Jason Song <nobodyiam@gmail.com>

delete create app in one env; refactor the logic of create app

913778c

Merge branch 'feat/portal-allow-openapi-create-app' of https://github…

24ea949

….com/Anilople/apollo into feat/portal-allow-openapi-create-app

Anilople commented Aug 16, 2023

View reviewed changes

apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/AppService.java Show resolved Hide resolved

Anilople requested a review from nobodyiam August 16, 2023 14:37

nobodyiam reviewed Aug 18, 2023

View reviewed changes

Anilople added 4 commits August 18, 2023 21:24

refactor: change createAppInLocal to private and remove '@transactional'

cbaa5e9

remove useless field

ab85347

remove useless check

911a2fa

refactor: path "apps/create" -> "apps"

b4f391e

Anilople requested a review from nobodyiam August 18, 2023 13:41

nobodyiam added this to the 2.2.0 milestone Aug 23, 2023

Anilople added 2 commits August 27, 2023 15:06

sync client's change

095a7ee

feat: allow assignAppRoleToConsumer when use openapi

dfae373

Anilople commented Aug 28, 2023

View reviewed changes

apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/AppController.java Outdated Show resolved Hide resolved

Anilople added 3 commits August 28, 2023 22:41

Update ServerAppOpenApiService.java

2b1131c

feat: add '@transactional' to controller method

9805d9f

move Transactional position and delete rollbackOn

1e7941b

Merge branch 'master' into feat/portal-allow-openapi-create-app

4f717ee

nobodyiam reviewed Sep 5, 2023

View reviewed changes

...lo-portal/src/main/java/com/ctrip/framework/apollo/portal/controller/ConsumerController.java Outdated Show resolved Hide resolved

feat: allow assignCreateApplicationRoleToConsumer when create consumer

10e973e

Anilople commented Sep 10, 2023

View reviewed changes

...-portal/src/main/java/com/ctrip/framework/apollo/portal/entity/vo/consumer/ConsumerInfo.java Show resolved Hide resolved

fix: button don't work

19ce123

nobodyiam reviewed Sep 12, 2023

View reviewed changes

Update apollo-portal/src/main/java/com/ctrip/framework/apollo/openapi…

474cbfd

…/v1/controller/AppController.java Co-authored-by: Jason Song <nobodyiam@gmail.com>

Anilople and others added 6 commits September 17, 2023 15:02

Update apollo-portal/src/main/resources/static/i18n/en.json

5d0dae1

Co-authored-by: Jason Song <nobodyiam@gmail.com>

Update apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/…

5bef9a2

…controller/ConsumerController.java Co-authored-by: Jason Song <nobodyiam@gmail.com>

Apply suggestions from code review

901aab6

Co-authored-by: Jason Song <nobodyiam@gmail.com>

remove red style

5f209b2

change width same as table header

bf8dfd9

fix: submitBtnDisabled should change to false after warning user

6fcf5df

nobodyiam reviewed Sep 17, 2023

View reviewed changes

apollo-portal/src/main/resources/static/open/add-consumer.html Outdated Show resolved Hide resolved

Anilople added 4 commits September 17, 2023 21:57

test: Consumer create and app create

978b350

change to checkbox

9249c7a

upgrade to junit5

cb81300

test: add test of isAllowCreateApplication

f6778e6

Anilople requested a review from nobodyiam September 17, 2023 14:28

Anilople added 2 commits September 19, 2023 21:15

remove apollorequiredfield

20a860f

Update CHANGES.md

075c7a4

nobodyiam approved these changes Sep 20, 2023

View reviewed changes

nobodyiam merged commit a23b3a8 into apolloconfig:master Sep 20, 2023
12 checks passed

github-actions bot locked and limited conversation to collaborators Sep 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(openapi): allow user create app via openapi #4954

feat(openapi): allow user create app via openapi #4954

Anilople commented Aug 11, 2023 •

edited

Loading

Anilople commented Aug 16, 2023

codecov bot commented Sep 1, 2023 •

edited

Loading

nobodyiam commented Sep 18, 2023

nobodyiam commented Sep 19, 2023

Anilople commented Sep 19, 2023

Anilople commented Sep 19, 2023

nobodyiam left a comment

nobodyiam commented Dec 3, 2023

feat(openapi): allow user create app via openapi #4954

feat(openapi): allow user create app via openapi #4954

Conversation

Anilople commented Aug 11, 2023 • edited Loading

What's the purpose of this PR

Which issue(s) this PR fixes:

Brief changelog

Anilople commented Aug 16, 2023

codecov bot commented Sep 1, 2023 • edited Loading

Codecov Report

nobodyiam commented Sep 18, 2023

nobodyiam commented Sep 19, 2023

Anilople commented Sep 19, 2023

Anilople commented Sep 19, 2023

nobodyiam left a comment

Choose a reason for hiding this comment

nobodyiam commented Dec 3, 2023

Anilople commented Aug 11, 2023 •

edited

Loading

codecov bot commented Sep 1, 2023 •

edited

Loading